Re: [PATCH v5 2/4] PCI: qcom: add support for the Shikra PCIe controller

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] PCI: qcom: legacy qcom,pcie-shikra compatible naming in
  qcom_pcie_match
--

commit 929cee16b1f49a3c3c6d6d911e16e73ada7cd7fc
Author: Sushrut Shree Trivedi <sushrut.trivedi@oss.qualcomm.com>

PCI: qcom: add support for the Shikra PCIe controller

This commit adds the qcom,pcie-shikra compatible entry to qcom_pcie_match
using cfg_1_9_0.

> diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c
> index eba1b2cb30f0a..7573c509d7ce6 100644
> --- a/drivers/pci/controller/dwc/pcie-qcom.c
> +++ b/drivers/pci/controller/dwc/pcie-qcom.c
> @@ -2623,6 +2623,7 @@ static const struct of_device_id qcom_pcie_match[] = {
>  	{ .compatible = "qcom,pcie-sc8280xp", .data = &cfg_sc8280xp },
>  	{ .compatible = "qcom,pcie-sdm845", .data = &cfg_2_7_0 },
>  	{ .compatible = "qcom,pcie-sdx55", .data = &cfg_1_9_0 },
> +	{ .compatible = "qcom,pcie-shikra", .data = &cfg_1_9_0 },

[Severity: Low]
Should this compatible string be "qcom,shikra-pcie" (sorted at the top of
qcom_pcie_match alongside "qcom,hawi-pcie" and "qcom,nord-pcie") instead of
"qcom,pcie-shikra"?

Documentation/devicetree/bindings/arm/qcom-soc.yaml marks qcom,pcie-* as a
legacy pattern that must not be used for new entries and already includes
shikra in the preferred qcom,SoC-IP pattern, so using qcom,pcie-shikra locks
in a non-conforming DT ABI name and required adding a one-off const exception
to qcom-soc.yaml.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261112083355.3884737-1-linghui.wu@oss.qualcomm.com?part=2