Re: [PATCH ath-next 04/15] wifi: ath12k: add QMI support for extended firmware binary download

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] wifi: ath12k: missing support check in
  ath12k_qmi_request_target_cap()
--

commit d06cd02bf95410a2331b0d3861ca5bf0baa15ac2
Author: Madhavan Ganesan <madhavan.ganesan@oss.qualcomm.com>

wifi: ath12k: add QMI support for extended firmware binary download

This commit adds QMI support for the combined extended firmware binary
download request (QMI_WLANFW_EXT_FW_BIN_DOWNLOAD_REQ_V01) and the
mcss_ucode.bin image required by QCN9575.

> diff --git a/drivers/net/wireless/ath/ath12k/qmi.c b/drivers/net/wireless/ath/ath12k/qmi.c
> index 69512b82aa3b3..3b60d624b0aa5 100644
> --- a/drivers/net/wireless/ath/ath12k/qmi.c
> +++ b/drivers/net/wireless/ath/ath12k/qmi.c

[ ... ]

> @@ -3115,6 +3289,27 @@ int ath12k_qmi_request_target_cap(struct ath12k_base *ab)
>  		}
>  	}
>  
> +	if (resp.ext_fw_bin_download_support_valid &&
> +	    resp.ext_fw_bin_download_bitmap_valid) {
> +		ab->qmi.ext_fw_bin_download_bitmap =
> +			resp.ext_fw_bin_download_bitmap;
> +		ath12k_dbg(ab, ATH12K_DBG_QMI, "qmi extended firmware bin download bitmap 0x%x\n",
> +			   resp.ext_fw_bin_download_bitmap);
> +
> +		if (ab->qmi.ext_fw_bin_download_bitmap &
> +		    ~QMI_WLANFW_EXT_FW_BIN_TYPE_HOST_SUPPORTED_MASK) {
> +			ath12k_warn(ab, "Invalid ext_fw_bin_download_bitmap 0x%x, host-unsupported bits set\n",
> +				    ab->qmi.ext_fw_bin_download_bitmap);
> +			ret = -EINVAL;
> +			goto out;
> +		}
> +		ab->qmi.ext_fw_bin_download_support = !!resp.ext_fw_bin_download_support;
> +		ath12k_dbg(ab, ATH12K_DBG_QMI, "qmi extended firmware bin download supported\n");
> +	} else {
> +		ab->qmi.ext_fw_bin_download_support = false;
> +		ab->qmi.ext_fw_bin_download_bitmap = 0;
> +	}

[Severity: Medium]
Should this condition also check resp.ext_fw_bin_download_support?

QMI_OPT_FLAG sets ext_fw_bin_download_support_valid whenever TLV 0x2B is
present, even when ext_fw_bin_download_support is 0.  If firmware sends
both TLVs with ext_fw_bin_download_support set to 0, this block still
stores and validates ext_fw_bin_download_bitmap (failing target capability
negotiation with -EINVAL if any unused bit is set) and logs that extended
firmware binary download is supported.

Also, if ext_fw_bin_download_support is non-zero and
ext_fw_bin_download_bitmap is 0, the mask check passes here and defers the
failure until ath12k_qmi_wlanfw_ext_fw_bin_mem_info_send(), after regdb,
board data, and calibration data have already been downloaded.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261112-wifi8_qcn9575_bringup-v1-0-3f30fbc2bb69@oss.qualcomm.com?part=4