Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Kanak Shilledar" <kanak.shilledar@axis.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v9 1/7] dt-bindings: iio: imu: icm42600: Drop interrupt requirement
Date: Thu, 12 Nov 2026 14:38:26 +0000	[thread overview]
Message-ID: <sashiko-outbox-211353@kernel.org> (raw)
In-Reply-To: <20261112-b4-inv_icm42370p-v9-1-875c828a281e@axis.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dt-bindings: iio: imu: icm42600: inaccurate Fixes trailer
--

commit bb25ff93be540fe1b4383c714ff7cd075c29001b
Author: Kanak Shilledar <kanak.shilledar@axis.com>

> dt-bindings: iio: imu: icm42600: Drop interrupt requirement
>
> The devicetree documentation for the invensense,icm426xx devices was
> documented wrongly. As per the discussion in the thread[1], the IMUs can
> work in polling mode, making the interrupts as not required.
>
> Fix the dt-binding to not have interrupt property as mandatory. The
> driver will need to be fixed to not fail if interrupts are missing from
> the device tree. This will be done in a separate patch.
>
> Link: https://lore.kernel.org/linux-iio/20261018034134.2bf170a0@jic23-hlaptop/ [1]
> Fixes: 22addefdabdf ("dt-bindings: iio: imu: icm42600: Add icm42607")
> Signed-off-by: Kanak Shilledar <kanak.shilledar@axis.com>

[Severity: Low]
Commit 22addefdabdf ("dt-bindings: iio: imu: icm42600: Add icm42607") only
moved the existing top-level interrupts requirement into an allOf block to
exempt icm42607.  Should the Fixes tag instead point to the commit that
originally made interrupts required:

  Fixes: 45924b8fd2c9 ("dt-bindings: iio: imu: Add inv_icm42600 documentation")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261112-b4-inv_icm42370p-v9-0-875c828a281e@axis.com?part=1

  reply	other threads:[~2026-11-12 14:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-12 14:29 [PATCH v9 0/7] Add support for InvenSense ICM-42370-P accelerometer Kanak Shilledar
2026-11-12 14:29 ` [PATCH v9 1/7] dt-bindings: iio: imu: icm42600: Drop interrupt requirement Kanak Shilledar
2026-11-12 14:38   ` sashiko-bot [this message]
2026-11-12 14:29 ` [PATCH v9 2/7] dt-bindings: iio: imu: icm42600: Add ICM-42370-P Kanak Shilledar
2026-11-12 14:29 ` [PATCH v9 3/7] iio: imu: inv_icm42607: Simplify IIO channel macros Kanak Shilledar
2026-11-12 14:29 ` [PATCH v9 4/7] iio: imu: inv_icm42607: Initialize gyro based on chip_info Kanak Shilledar
2026-11-12 14:29 ` [PATCH v9 5/7] iio: imu: inv_icm42607: Add support for ICM-42370-P Kanak Shilledar
2026-11-12 14:29 ` [PATCH v9 6/7] iio: imu: inv_icm42607: Implement MREGx register access Kanak Shilledar
2026-11-12 14:29 ` [PATCH v9 7/7] iio: imu: inv_icm42607: Add accelerometer calibbias support Kanak Shilledar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-211353@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kanak.shilledar@axis.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox