From: sashiko-bot@kernel.org
To: "Krzysztof Kozlowski" <krzysztof.kozlowski@oss.qualcomm.com>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org
Cc: robh@kernel.org, conor+dt@kernel.org, wsa+renesas@sang-engineering.com
Subject: Re: [PATCH v2] dt-bindings: display: panel: Make DSI panels port optional
Date: Thu, 12 Nov 2026 15:15:35 +0000 [thread overview]
Message-ID: <sashiko-outbox-211417@kernel.org> (raw)
In-Reply-To: <20261112150650.137216-2-krzysztof.kozlowski@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dt-bindings: display: panel: ilitek,ili9806e: port made optional
for SPI panel
--
commit bcf90e9f5f8315b117fe2401d0e209382d33f585
Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
dt-bindings: display: panel: Make DSI panels port optional
This commit removes the port property from the required list in several
DSI display panel Device Tree binding schemas so that panels placed
directly under a DSI bus node do not require an OF graph port.
> diff --git a/Documentation/devicetree/bindings/display/panel/ilitek,ili9806e.yaml b/Documentation/devicetree/bindings/display/panel/ilitek,ili9806e.yaml
> index 2080d9e0ffac4..9a2602ddd9060 100644
> --- a/Documentation/devicetree/bindings/display/panel/ilitek,ili9806e.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/ilitek,ili9806e.yaml
> @@ -33,7 +33,6 @@ required:
> - vdd-supply
> - reset-gpios
> - backlight
> - - port
>
> if:
> properties:
[Severity: Low]
Should port remain required in the conditional then branch for
rocktech,rk050hr345-ct106a?
While densitron,dmt028vghmcmi-1d and ortustech,com35h3p70ulc are MIPI-DSI
panels, rocktech,rk050hr345-ct106a is an SPI-controlled DPI/RGB panel
(registered with DRM_MODE_CONNECTOR_DPI in ili9806e_spi_probe()). Because
its node sits under an SPI controller rather than a DSI host, the RGB
display controller still needs the OF graph port to link to the panel.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261112150650.137216-2-krzysztof.kozlowski@oss.qualcomm.com?part=1
prev parent reply other threads:[~2026-11-12 15:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 15:06 [PATCH v2] dt-bindings: display: panel: Make DSI panels port optional Krzysztof Kozlowski
2026-11-12 15:15 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-211417@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox