From: sashiko-bot@kernel.org
To: "Luca Weiss" <luca.weiss@fairphone.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v2] arm64: dts: qcom: Add Samsung Galaxy Book2 Go
Date: Thu, 12 Nov 2026 20:54:40 +0000 [thread overview]
Message-ID: <sashiko-outbox-211833@kernel.org> (raw)
In-Reply-To: <20261112-book2go-v2-1-12691134e34e@fairphone.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] arm64: dts: qcom: missing qcom,vmid property in recreated
rmtfs_mem node
--
commit b1d940dc3b330b7fb51fb7db7589ce050a146ccf
Author: Jasper Korten <jja2000@gmail.com>
arm64: dts: qcom: Add Samsung Galaxy Book2 Go
This commit adds initial device tree support for the Samsung Galaxy Book2
Go laptop based on the Qualcomm SC7280 SoC.
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-samsung-galaxy-book2-go.dts b/arch/arm64/boot/dts/qcom/sc7280-samsung-galaxy-book2-go.dts
> new file mode 100644
> index 0000000000000..51f0a92d0026b
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sc7280-samsung-galaxy-book2-go.dts
> @@ -0,0 +1,644 @@
[ ... ]
> +/delete-node/ &ipa_fw_mem;
> +/delete-node/ &rmtfs_mem;
> +/delete-node/ &wpss_mem;
> +/delete-node/ &xbl_mem;
[ ... ]
> + reserved-memory {
> + wpss_mem: wpss@84800000 {
> + reg = <0x0 0x84800000 0x0 0x1900000>;
> + no-map;
> + };
> +
> + rmtfs_mem: rmtfs@a0800000 {
> + compatible = "qcom,rmtfs-mem";
> + reg = <0x0 0xa0800000 0x0 0x300000>;
> + no-map;
> +
> + qcom,client-id = <1>;
> + };
[Severity: Medium]
Should the recreated rmtfs_mem node keep qcom,vmid = <QCOM_SCM_VMID_MSS_MSA>
from kodiak.dtsi?
Deleting &rmtfs_mem and recreating it without qcom,vmid causes
qcom_rmtfs_mem_probe() to skip qcom_scm_assign_mem(), which leaves the
RMTFS buffer unassigned to the modem in the hypervisor stage-2 page tables
unless the boot firmware already assigned it.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261112-book2go-v2-1-12691134e34e@fairphone.com?part=1
prev parent reply other threads:[~2026-11-12 20:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 20:24 [PATCH v2] arm64: dts: qcom: Add Samsung Galaxy Book2 Go Luca Weiss
2026-11-12 20:54 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-211833@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox