From: sashiko-bot@kernel.org
To: erebion <erebion@erebion.eu>
Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v4 05/12] arm64: dts: qcom: sm6350-lena: Enable Bluetooth
Date: Fri, 13 Nov 2026 01:51:01 +0000 [thread overview]
Message-ID: <sashiko-outbox-212075@kernel.org> (raw)
In-Reply-To: <20261113-pdx213-upstream-3-v4-5-4b01c50a821c@erebion.eu>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] arm64: dts: qcom: Signed-off-by and Author use handle instead
of real name
--
commit a88dbe84a474608356cf7418da893f73d6055164
Author: erebion <erebion@erebion.eu>
> arm64: dts: qcom: sm6350-lena: Enable Bluetooth
>
> Configure the required regulators for Bluetooth and enable it on the
> Xperia 10 III.
>
> Signed-off-by: erebion <erebion@erebion.eu>
[Severity: High]
Could the Author header and Signed-off-by trailer use a real full name
instead of the handle "erebion"? Documentation/process/submitting-patches.rst
requires a real human name to certify the Developer's Certificate of Origin.
Also, this isn't a bug, but the commit message says it configures the
regulators for Bluetooth, whereas the PM6350 and PM6150L regulators are
already defined in the board DTS and this patch only references their
phandles in the bluetooth node.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261113-pdx213-upstream-3-v4-0-4b01c50a821c@erebion.eu?part=5
next prev parent reply other threads:[~2026-11-13 1:51 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 1:24 [PATCH v4 00/12] Enable more nodes for the Xperia 10 III erebion
2026-11-13 1:24 ` [PATCH v4 01/12] arm64: dts: qcom: sm6350-lena: Add flash LED erebion
2026-11-13 1:32 ` sashiko-bot
2026-11-13 1:24 ` [PATCH v4 02/12] arm64: dts: qcom: sm6350-lena: rename touch-en-regulator erebion
2026-11-13 1:28 ` sashiko-bot
2026-11-13 1:44 ` erebion
2026-11-13 1:24 ` [PATCH v4 03/12] arm64: dts: qcom: sm6350-lena: Add qcom,rmtfs-mem node erebion
2026-11-13 1:30 ` sashiko-bot
2026-11-13 1:24 ` [PATCH v4 04/12] arm64: dts: qcom: sm6350-lena: Enable ADSP, CDSP, IPA & MPSS erebion
2026-11-13 1:40 ` sashiko-bot
2026-11-13 1:24 ` [PATCH v4 05/12] arm64: dts: qcom: sm6350-lena: Enable Bluetooth erebion
2026-11-13 1:51 ` sashiko-bot [this message]
2026-11-13 1:24 ` [PATCH v4 06/12] arm64: dts: qcom: sm6350-lena: Enable wifi erebion
2026-11-13 1:29 ` sashiko-bot
2026-11-13 1:24 ` [PATCH v4 07/12] arm64: dts: qcom: sm6350-lena: Enable PM7250B erebion
2026-11-13 1:34 ` sashiko-bot
2026-11-13 1:24 ` [PATCH v4 08/12] arm64: dts: qcom: sm6350-lena: Enable PMK8350 erebion
2026-11-13 1:33 ` sashiko-bot
2026-11-13 1:24 ` [PATCH v4 09/12] arm64: dts: qcom: sm6350-lena: Add PM7250B thermals erebion
2026-11-13 1:33 ` sashiko-bot
2026-11-13 1:24 ` [PATCH v4 10/12] arm64: dts: qcom: sm6350-lena: Add PMK8350 thermals erebion
2026-11-13 1:33 ` sashiko-bot
2026-11-13 1:24 ` [PATCH v4 11/12] arm64: dts: qcom: sm6350-lena: Add PM6150L thermals erebion
2026-11-13 1:38 ` sashiko-bot
2026-11-13 1:24 ` [PATCH v4 12/12] arm64: dts: qcom: sm6350-lena: enable remaining i2c busses erebion
2026-11-13 1:35 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-212075@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=erebion@erebion.eu \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox