Re: [PATCH v17 06/10] qcom-tgu: Add TGU decode support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] qcom-tgu: transposed step_index and operation_index in
  tgu_dataset_rw()
--

commit be12a60019509b692fe89759e5c9e8345578b9d2
Author: Songwei Chai <songwei.chai@oss.qualcomm.com>

qcom-tgu: Add TGU decode support

This commit adds sysfs attributes and register programming for the
per-step condition decode registers on the Qualcomm TGU.

> diff --git a/drivers/hwtracing/qcom/tgu.c b/drivers/hwtracing/qcom/tgu.c
> index c00e95e68214c..72b98a96d7f20 100644
> --- a/drivers/hwtracing/qcom/tgu.c
> +++ b/drivers/hwtracing/qcom/tgu.c
> @@ -18,8 +18,8 @@
>  
>  struct tgu_attribute {
>  	struct device_attribute attr;
> +	enum operation_index operation_index;
>  	u8 step_index;
> -	u8 priority;
>  	u8 reg_num;
>  };

[Severity: High]
Does placing operation_index before step_index in struct tgu_attribute
transpose the two fields in every attribute initialized by
tgu_dataset_rw()?

tgu_dataset_rw() uses positional initialization and still passes
step_index before the priority/operation argument:

drivers/hwtracing/qcom/tgu.c:
    #define tgu_dataset_rw(name, step_index, priority, reg_num)              \
    	(&((struct tgu_attribute[]){ {                                   \
    		__ATTR(name, 0644, tgu_dataset_show, tgu_dataset_store), \
    		step_index,                                              \
    		priority,                                                \
    		reg_num,                                                 \
    	} })[0].attr.attr)

As a result, operation_index receives step_index (0..7) and step_index
receives the priority or TGU_CONDITION_DECODE (4).  In
tgu_node_visible(), tgu_dataset_show(), and tgu_dataset_store(), this
hides attributes for steps 5..7, maps step[0:3]_condition_decode to
drvdata->priority at step 4, and transposes step and priority indices.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261113024935.3173715-1-songwei.chai@oss.qualcomm.com?part=6