Re: [PATCH v3 5/6] arm64: dts: qcom: kodiak: use thermal hw-bin trips

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] arm64: dts: qcom: kodiak: duplicate @180 unit-address in qfprom
--

commit e6d4eae865bd91c0bd0f76066337d957b0861f51
Author: Amit Kucheria <amit.kucheria@oss.qualcomm.com>

arm64: dts: qcom: kodiak: use thermal hw-bin trips

This commit adds jtag-id and feat-id nvmem cells to the tsens nodes in
kodiak.dtsi and converts passive mitigation trip points to per-bin
temperature values.

> diff --git a/arch/arm64/boot/dts/qcom/kodiak.dtsi b/arch/arm64/boot/dts/qcom/kodiak.dtsi
> index 10e9a5279ed60..79553bf43a7a2 100644
> --- a/arch/arm64/boot/dts/qcom/kodiak.dtsi
> +++ b/arch/arm64/boot/dts/qcom/kodiak.dtsi
> @@ -1028,6 +1028,18 @@ gpu_speed_bin: gpu-speed-bin@1e9 {
>  				reg = <0x1e9 0x2>;
>  				bits = <5 8>;
>  			};
> +
> +			jtag_id: jtag-id@180 {
> +				reg = <0x180 0x4>;
> +				/* bits = <offset width>: 20 bits at offset 0 */
> +				bits = <0 20>;
> +			};
> +
> +			feat_id: feat-id@180 {
> +				reg = <0x180 0x4>;
> +				/* bits = <offset width>: 8 bits at offset 20 */
> +				bits = <20 8>;
> +			};
>  		};

[Severity: Low]
Does giving both jtag-id@180 and feat-id@180 the same @180 unit-address
trigger a dtc unique_unit_address warning when building DTBs with W=1?

qfprom_fixup_dt_cell_info() aligns byte-addressed QFPROM cells to 4-byte
words at runtime, so feat-id can be described at its starting byte offset
(feat-id@182 with reg = <0x182 0x2> and bits = <4 8>, and jtag-id@180 with
reg = <0x180 0x3>), placed before gpu-speed-bin@1e9 in ascending
unit-address order.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261113-thermal_bin-v3-0-878df6eef8bc@oss.qualcomm.com?part=5