Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Michal Simek" <michal.simek@amd.com>
Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH] arm64: zynqmp: Disable DP for Kria SOM
Date: Fri, 13 Nov 2026 12:57:51 +0000	[thread overview]
Message-ID: <sashiko-outbox-212800@kernel.org> (raw)
In-Reply-To: <ef31d389e963485d19ea5837d442ab0b1ac39b6a.1794574131.git.michal.simek@amd.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] arm64: dts: xilinx: missing Fixes trailer for Kria SOM DP
  disablement
--

commit e2f41fe54ad1036405ec0ba6b0b3df56fe2caed9
Author: Michal Simek <michal.simek@amd.com>

> arm64: zynqmp: Disable DP for Kria SOM
>
> DP is enabled via DT overlays and there is no need to have it enabled for
> SOM only. Schema validation also reports that phys/phy-names are required
> property which is not valid for SOM only DTs.
>
> Signed-off-by: Michal Simek <michal.simek@amd.com>

[Severity: Low]
Since enabling zynqmp_dpsub in the base SOM DT without phys or phy-names
broke schema validation and caused zynqmp_dp_phy_probe() to fail on
SOM-only DTBs, should this include:

  Fixes: e05d2f969cb5 ("arm64: zynqmp: Add dmas, dp, rtc, watchdogs and opp nodes for SOM")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/ef31d389e963485d19ea5837d442ab0b1ac39b6a.1794574131.git.michal.simek@amd.com?part=1

      reply	other threads:[~2026-11-13 12:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-13 12:48 [PATCH] arm64: zynqmp: Disable DP for Kria SOM Michal Simek
2026-11-13 12:57 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-212800@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=michal.simek@amd.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox