Re: [PATCH v2] arm64: dts: rockchip: support camera module on Haikou Video Demo on RK3399 Puma

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] arm64: dts: rockchip: missing reg and address/size cells in
  &isp1 port@0
--

commit a25f92051078c649413a94889902e838a237378c
Author: Quentin Schulz <quentin.schulz@cherry.de>

arm64: dts: rockchip: support camera module on Haikou Video Demo on RK3399 Puma

This commit adds device tree overlay nodes for the OV5675 camera sensor and
DW9714 focus lens driver on the RK3399 Puma Haikou Video Demo adapter,
enabling isp1, isp1_mmu, and mipi_dsi1.

> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-puma-haikou-video-demo.dtso b/arch/arm64/boot/dts/rockchip/rk3399-puma-haikou-video-demo.dtso
> index 141a921a06e47..013920d9a3392 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-puma-haikou-video-demo.dtso
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-puma-haikou-video-demo.dtso

[ ... ]

> @@ -122,6 +129,53 @@ pca9670: gpio@27 {
>  		pinctrl-names = "default";
>  		reset-gpios = <&gpio4 RK_PD6 GPIO_ACTIVE_LOW>;
>  	};
> +
> +	camera@36 {

[ ... ]

> +	};
> +};
> +
> +&isp1 {
> +	status = "okay";
> +
> +	ports {
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		port@0 {
> +			mipi_in_cam: endpoint@0 {
> +				reg = <0>;
> +				data-lanes = <1 2>;
> +				link-frequencies = /bits/ 64 <450000000>;
> +				remote-endpoint = <&cam_output>;
> +			};
> +		};
> +	};
> +};

[Severity: Low]
Should port@0 define reg = <0>, #address-cells = <1>, and #size-cells = <0>
to match isp1 in arch/arm64/boot/dts/rockchip/rk3399-base.dtsi?

Because dtc compiles this overlay into a standalone .dtbo before fdtoverlay
merges it with the base DTB, #address-cells and #size-cells on ports apply
only to port@0 and are not inherited by its child endpoint@0.  Without them
on port@0, compiling the overlay triggers dtc reg_format,
avoid_default_addr_size, and graph_endpoint warnings on endpoint@0 (plus
unit_address_vs_reg and avoid_unnecessary_addr_size warnings with W=1
because port@0 has no reg property in the overlay).

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261113-rk3399-puma-haikou-video-demo-cam-v2-1-e71acf307f92@cherry.de?part=1