Re: [PATCH v2 3/5] arm64: dts: imx95-phyflex-libra-rdk: Add overlays

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] arm64: dts: imx95-phyflex-libra-rdk: missing OF graph link in
  BT overlay
--

commit 924f1473173fca2dbc62cd020eeba54504832201
Author: Benjamin Hahn <B.Hahn@phytec.de>

arm64: dts: imx95-phyflex-libra-rdk: Add overlays

This commit adds devicetree overlays for the SoM temperature sensors and
for M.2 Key-E Wi-Fi/Bluetooth cards using the nxp,88w8987-bt binding on
the phyFLEX-i.MX 95 Libra RDK.

> diff --git a/arch/arm64/boot/dts/freescale/imx95-phyflex-libra-rdk-bluetooth-88w8987.dtso b/arch/arm64/boot/dts/freescale/imx95-phyflex-libra-rdk-bluetooth-88w8987.dtso
> new file mode 100644
> index 0000000000000..1601e04b3940f
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx95-phyflex-libra-rdk-bluetooth-88w8987.dtso
> @@ -0,0 +1,24 @@
> +// SPDX-License-Identifier: (GPL-2.0-or-later OR MIT)
> +/*
> + * Copyright (C) 2026 PHYTEC Messtechnik GmbH
> + */
> +/dts-v1/;
> +/plugin/;
> +
> +#include <dt-bindings/gpio/gpio.h>
> +
> +&lpuart8 {
> +	bluetooth {
> +		compatible = "nxp,88w8987-bt";
> +		fw-init-baudrate = <115200>;
> +	};
> +};

[Severity: Medium]
Does this overlay also need OF graph endpoints linking lpuart8 and
port@3 of m2-key-e-connector?

In imx95-phyflex-libra-rdk.dts, m2-key-e-connector uses
compatible = "pcie-m2-e-connector" and claims w-disable2-gpios.  When
CONFIG_POWER_SEQUENCING_PCIE_M2 is enabled, pwrseq_pcie_m2_probe()
requests w-disable2-gpios with GPIOD_OUT_HIGH, holding the active-low
W_nDISABLE2 line asserted until a consumer enables the "uart" power
sequencer target.

In drivers/bluetooth/btnxpuart.c, nxp_serdev_probe() checks
nxp_m2_connector_is_available() and calls pwrseq_get(..., "uart"), both
of which require an OF graph link between the UART controller and the
M.2 connector; without it, W_nDISABLE2 remains asserted and the M.2
Bluetooth radio stays disabled.  Adding the OF graph endpoints in this
overlay rather than the base DTB also keeps lpuart8 exposed as a normal
TTY device when the Bluetooth overlay is not applied.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261113-wip-bhahn-imx95_upstreaming-v2-0-3ef58af5e689@phytec.de?part=3