Re: [PATCH v1 10/10] ARM: tegra: Add CSI node for Tegra114

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] ARM: dts: tegra114: undefined TEGRA114_CLK_CSIA_PAD and
  TEGRA114_CLK_CSIB_PAD in csi@800
--

commit f51e7b055195911c3530d9e3bca74397442d3256
Author: Svyatoslav Ryhel <clamor95@gmail.com>

ARM: tegra: Add CSI node for Tegra114

This commit adds the CSI child node under the VI node in the Tegra114
device tree and shrinks the VI node's reg range to accommodate it.

> diff --git a/arch/arm/boot/dts/nvidia/tegra114.dtsi b/arch/arm/boot/dts/nvidia/tegra114.dtsi
> index a5958f3a965b2..0d1328c4d3c8e 100644
> --- a/arch/arm/boot/dts/nvidia/tegra114.dtsi
> +++ b/arch/arm/boot/dts/nvidia/tegra114.dtsi
> @@ -53,7 +53,7 @@ host1x@50000000 {
>  
>  		vi@54080000 {
>  			compatible = "nvidia,tegra114-vi";
> -			reg = <0x54080000 0x00040000>;
> +			reg = <0x54080000 0x00000800>;
>  			interrupts = <GIC_SPI 69 IRQ_TYPE_LEVEL_HIGH>;
>  			clocks = <&tegra_car TEGRA114_CLK_VI>;
>  			resets = <&tegra_car 20>;
> @@ -64,6 +64,38 @@ vi@54080000 {
>  			iommus = <&mc TEGRA_SWGROUP_VI>;
>  
>  			status = "disabled";
> +
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +
> +			ranges = <0x0 0x54080000 0x4000>;
> +
> +			csi@800 {
> +				compatible = "nvidia,tegra114-csi";
> +				reg = <0x800 0x200>;
> +				clocks = <&tegra_car TEGRA114_CLK_CSI>,
> +					 <&tegra_car TEGRA114_CLK_CSIA_PAD>,
> +					 <&tegra_car TEGRA114_CLK_CSIB_PAD>,
> +					 <&tegra_car TEGRA114_CLK_CILAB>,
> +					 <&tegra_car TEGRA114_CLK_CILCD>,
> +					 <&tegra_car TEGRA114_CLK_CILE>;
> +				clock-names = "csi", "csia-pad", "csib-pad",
> +					      "cilab", "cilcd", "cile";

[Severity: High]
Are TEGRA114_CLK_CSIA_PAD and TEGRA114_CLK_CSIB_PAD defined?

include/dt-bindings/clock/tegra114-car.h does not define either macro, and
tegra114_periph_clk_init() in drivers/clk/tegra/clk-tegra114.c does not
register the csia_pad or csib_pad clock gates.  Leaving these macros
undefined causes dtc to fail with a syntax error when building any
Tegra114 device tree.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261113161819.36847-1-clamor95@gmail.com?part=10