From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794588237; b=yWUVZTEFSgGeD9V4IpCbck2aPCSqIKAt+wUfAY4czezIQcuJFa3jeEgEoFc+fPss9ycJ jEPjbemCkwbvtJ71gFy9ZTxgSKTINUjFq3tfAhA9eMOB5h3FiTH/JiGWEYL5c0tenzhHG eN/1bmSEHaYpQRFa2CnsDgkcYXOICrfrlhaUHVTBlQ40dboMeu64yHPGy1QoXRBZ2l9ld RGFgp8LJfXMwixWrXa1ibYspNsDhJEZihyhzwtPALf4lEoI5iUbxMo7AYLCNtWuVPw8cx L0aSnvVFtr6XskI5or4gMSFhITGO4IeK4Ua25wwkp/AOYqu5oSO0wdt/VJbXR+vKsXg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794588237; h=Received:DKIM-Signature:Message-ID:From:Subject:Reply-To:To:Cc: In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=SnrOxxyXskTzj64rBmLghaWVBlsWoyfEZUJsvyzwTTo=; b=zNIdpyU41A/JMM1s0B4j3mA8M22q9FA5ID+mnAjEq6zuNfmvcjPanLYyOQFg87QMNmdi qRvKXH41lBM+v0Xt6EDSoeYPP9Qmur8WBr63yYUNQBKh4TcPDAFSpgn0nv96qH/kVfw0F cehUkadrQXWDIAln6PiFWR1S4+mAIWWU+NXPLpat1GkYc067X1LZpw3B9Jx68HRpMtI4n hPaege+8YTJHuk0ExJ8DPGxYr49fTzD3MEALhvqP+J0trXk7AxOuNcugjtDLOyUOdkuX1 1++k+jALx8wJlxiviflZDbpKyFsDmSBthAj4Ffkd5f//g2QBpxu+dpcWPtxVKkKCgjw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=YUpubfOB; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E6F6606A336 for ; Fri, 13 Nov 2026 16:43:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=YUpubfOB Received: by smtp.kernel.org (Postfix) with ESMTPSA id DB46C1F000C4; Fri, 13 Nov 2026 16:43:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794588237; bh=SnrOxxyXskTzj64rBmLghaWVBlsWoyfEZUJsvyzwTTo=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=YUpubfOB0oRAsMZ3s341lxbZmb4j0K9E06d+SnqZjysJGaLavZed9P3afnULKxnQ+ xMiJVV0iNVTHqDOnTXwA/90KrRDfH9iSbM9E8Zyuv0LHSQaFq6Oglkb9xO8+oB5F4I Xxm6w3f5rj0up5nnUekRnn8eIY8nQonBE10Q5M3bCIvOA8IivLsIE9s5wAdw56bXnf aQHFCoGQ7qlmswKIwM9y1tGA9lUDkmMYhUD4mZU/4YjBMazHE8FRagx6FmHPbxgZtx 49lmcqSk8k7TD5S3HGLK8CVC5lfMJWu2Kcl9pV3kjTax+YPe5P04VTsx+c8nuK24cy 5aI5j7RA+qvsg== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v1 01/10] staging: media: tegra-video: Move driver to media/platform/nvidia Reply-To: sashiko-reviews@lists.linux.dev To: "Svyatoslav Ryhel" Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org, media-ci@linuxtv.org In-Reply-To: <20261113161819.36847-2-clamor95@gmail.com> References: <20261113161819.36847-1-clamor95@gmail.com> <20261113161819.36847-2-clamor95@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 13 Nov 2026 16:43:56 +0000 X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Thank you for your contribution! Sashiko AI review found 2 potential issues to consider: - [Low] media: tegra-video: dangling staging path in MAINTAINERS after directory move - [Low] media: tegra-video: incomplete destaging leaves TODO file and staging hacks -- commit a8916ec654eff39d7e3b979839383852a183e987 Author: Svyatoslav Ryhel staging: media: tegra-video: Move driver to media/platform/nvidia This commit moves the Tegra Video Input driver from drivers/staging/media/tegra-video/ to drivers/media/platform/nvidia/tegra-video/. > diff --git a/drivers/media/platform/nvidia/Kconfig b/drivers/media/platfo= rm/nvidia/Kconfig > index b211b46877f63..53f34308f5aff 100644 > --- a/drivers/media/platform/nvidia/Kconfig > +++ b/drivers/media/platform/nvidia/Kconfig > @@ -3,3 +3,5 @@ > comment "NVidia media platform drivers" > =20 > source "drivers/media/platform/nvidia/tegra-vde/Kconfig" > + > +source "drivers/media/platform/nvidia/tegra-video/Kconfig" [Severity: Low] Should MAINTAINERS also be updated to point to drivers/media/platform/nvidia/tegra-video/? The TEGRA VIDEO DRIVER entry in MAINTAINERS still lists drivers/staging/media/tegra-video/, which causes scripts/get_maintainer.pl --self-test=3Dpatterns to report a broken file pattern and prevents get_maintainer.pl from matching the moved files. [ ... ] > diff --git a/drivers/staging/media/tegra-video/TODO b/drivers/media/platf= orm/nvidia/tegra-video/TODO > similarity index 100% > rename from drivers/staging/media/tegra-video/TODO > rename to drivers/media/platform/nvidia/tegra-video/TODO [Severity: Low] Should the staging TODO file and remaining staging workarounds be resolved or removed before moving this driver out of staging? Renaming drivers/staging/media/tegra-video/TODO leaves an open staging TODO list (ganged mode, Tegra210 RAW10 packed format support, suspend/resume, and v4l2-compliance verification) in drivers/media/platform/nvidia/tegra-video/TODO. In addition, tegra20_vi_enable() in tegra20.c still calls ioremap(TEGRA_APB_MISC_BASE, PAGE_SIZE) on a hardcoded physical address for an unsynchronized read-modify-write on a shared APB_MISC register, and __tegra_channel_try_format() in vi.c still calls the internal __v4l2_subdev_state_alloc() helper with a FIXME noting that drivers must not use it. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261113161819.3684= 7-1-clamor95@gmail.com?part=3D1