From: sashiko-bot@kernel.org
To: "Ryan Brue" <ryanbrue.dev@gmail.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v2 3/3] arm64: dts: mediatek: Add MT8173 Amazon suez
Date: Fri, 13 Nov 2026 17:16:15 +0000 [thread overview]
Message-ID: <sashiko-outbox-213289@kernel.org> (raw)
In-Reply-To: <20261113-rbrue-suez-upstreaming-amazon-suez-dts-v2-3-d3b8865fa50f@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] arm64: dts: mediatek: undocumented mediatek,mt8173-keypad
compatible enabled
--
commit 2503b241917cd19d3cef775979876bb2182fbb3e
Author: Ryan Brue <ryanbrue.dev@gmail.com>
arm64: dts: mediatek: Add MT8173 Amazon suez
This commit adds a device tree for the MT8173-based Amazon Fire HD 10
(2017) tablet (codename suez).
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173-amazon-suez.dts b/arch/arm64/boot/dts/mediatek/mt8173-amazon-suez.dts
> new file mode 100644
> index 0000000000000..042b41e7d5675
> --- /dev/null
> +++ b/arch/arm64/boot/dts/mediatek/mt8173-amazon-suez.dts
[ ... ]
> +&keyboard {
> + /* Each key is reported in all eight rows of its column */
> + keypad,num-rows = <8>;
> + keypad,num-columns = <9>;
> + linux,keymap = <MATRIX_KEY(0, 0, KEY_VOLUMEUP)
> + MATRIX_KEY(0, 1, KEY_VOLUMEDOWN)>;
> + debounce-delay-ms = <32>;
> + wakeup-source;
> + status = "okay";
> +};
[Severity: Low]
Does enabling &keyboard cause make dtbs_check to fail on
mt8173-amazon-suez.dtb?
The keyboard@10010000 node in arch/arm64/boot/dts/mediatek/mt8173.dtsi sets
compatible = "mediatek,mt8173-keypad", "mediatek,mt6779-keypad", and
"mediatek,mt8173-keypad" is not listed in
Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261113-rbrue-suez-upstreaming-amazon-suez-dts-v2-0-d3b8865fa50f@gmail.com?part=3
prev parent reply other threads:[~2026-11-13 17:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 16:42 [PATCH v2 0/3] arm64: dts: mediatek: Add the Amazon Fire HD 10 (2017) Ryan Brue
2026-11-13 16:42 ` [PATCH v2 1/3] dt-bindings: arm: mediatek: Add MT8173 Amazon suez Ryan Brue
2026-11-13 16:42 ` [PATCH v2 2/3] arm64: dts: mediatek: mt8173: Add the keypad controller Ryan Brue
2026-11-13 17:00 ` sashiko-bot
2026-11-13 16:42 ` [PATCH v2 3/3] arm64: dts: mediatek: Add MT8173 Amazon suez Ryan Brue
2026-11-13 17:16 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-213289@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=ryanbrue.dev@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox