Re: [PATCH net-next v3 1/2] dt-bindings: net: dsa: lantiq,gswip: add reset-gpios

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dt-bindings: net: dsa: lantiq,gswip: split GSW1xx into separate
  schema
--

commit 3590cf6c71e15fdb259e4e21a87a5fb546f5d150
Author: Joseph Telaak <joseph@telaak.dev>

dt-bindings: net: dsa: lantiq,gswip: add reset-gpios

This commit adds the reset-gpios property to the lantiq,gswip binding for
standalone GSW1xx switches and updates the RGMII slew-rate descriptions to
note that a hardware reset restores power-on defaults.

> diff --git a/Documentation/devicetree/bindings/net/dsa/lantiq,gswip.yaml b/Documentation/devicetree/bindings/net/dsa/lantiq,gswip.yaml
> index 49af5573e452d..89f78a1bc113d 100644
> --- a/Documentation/devicetree/bindings/net/dsa/lantiq,gswip.yaml
> +++ b/Documentation/devicetree/bindings/net/dsa/lantiq,gswip.yaml
> @@ -40,6 +40,11 @@ properties:
>        - const: mdio
>        - const: mii
>  
> +  reset-gpios:
> +    maxItems: 1
> +    description:
> +      GPIO connected to the hardware reset input of a standalone switch.
> +
>    mdio:
>      $ref: /schemas/net/mdio.yaml#
>      unevaluatedProperties: false

[ ... ]

> @@ -173,6 +180,7 @@ allOf:
>          mdio:
>            required:
>              - compatible
> +        reset-gpios: false
>      else:
>        properties:
>          reg:

[Severity: Low]
This isn't a bug, but would it make sense to split the standalone MDIO-based
GSW1xx switches into a separate binding schema instead of adding more
per-compatible exclusions here?

The SoC-integrated GSWIP variants and standalone GSW1xx switches sit on
different buses and already override or disable almost every top-level
property outside compatible and ports (reg, reg-names, mdio, gphy-fw, and now
reset-gpios) in the allOf if-then-else block.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261112-mxl-gsw1xx-reset-v3-0-863e82074893@telaak.dev?part=1