From: sashiko-bot@kernel.org
To: "Bjorn Andersson" <bjorn.andersson@oss.qualcomm.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 2/3] arm64: dts: qcom: glymur: Add ASUS Ascent QN10
Date: Sat, 14 Nov 2026 04:43:15 +0000 [thread overview]
Message-ID: <sashiko-outbox-214144@kernel.org> (raw)
In-Reply-To: <20261113-qn10-v1-2-e09b2aa7ccbe@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] arm64: dts: qcom: glymur: unused ec_int_n_default node and
header includes
--
commit 0ef1ffea3eda67a97118c03e5338af8067d89944
Author: Bjorn Andersson <bjorn.andersson@oss.qualcomm.com>
arm64: dts: qcom: glymur: Add ASUS Ascent QN10
This commit adds the DeviceTree for the ASUS Ascent QN10 desktop based on
the Qualcomm Snapdragon X2 Elite (Glymur) platform.
> diff --git a/arch/arm64/boot/dts/qcom/glymur-asus-ascent-qn10.dts b/arch/arm64/boot/dts/qcom/glymur-asus-ascent-qn10.dts
> new file mode 100644
> index 0000000000000..d61caa2b50222
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/glymur-asus-ascent-qn10.dts
> @@ -0,0 +1,670 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
> + */
> +/dts-v1/;
> +
> +#include "glymur-cob.dtsi"
> +
> +#include <dt-bindings/clock/qcom,rpmh.h>
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
> +#include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
[ ... ]
> +&tlmm {
> + gpio-reserved-ranges = <4 4>, /* EC Secure */
> + <10 2>, /* OOB UART */
> + <44 4>, /* TPM */
> + <65 1>, /* EC reset */
> + <100 1>; /* Board ID */
> +
> + ec_int_n_default: ec-int-n-state {
> + pins = "gpio66";
> + function = "gpio";
> + bias-disable;
> + };
[Severity: Low]
Is ec_int_n_default needed here? Nothing in this file or the included
dtsi files references &ec_int_n_default. Also, neither
dt-bindings/clock/qcom,rpmh.h nor dt-bindings/pinctrl/qcom,pmic-gpio.h is
used in this file.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261113-qn10-v1-0-e09b2aa7ccbe@oss.qualcomm.com?part=2
next prev parent reply other threads:[~2026-11-14 4:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-14 4:28 [PATCH 0/3] arm64: dts: qcom: glymur: Add ASUS Ascent QN10 Bjorn Andersson
2026-11-14 4:28 ` [PATCH 1/3] dt-bindings: arm: qcom: " Bjorn Andersson
2026-11-14 4:28 ` [PATCH 2/3] arm64: dts: qcom: glymur: " Bjorn Andersson
2026-11-14 4:43 ` sashiko-bot [this message]
2026-11-14 4:28 ` [PATCH 3/3] firmware: qcom: Allow QSEECOM on " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-214144@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=bjorn.andersson@oss.qualcomm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox