From: sashiko-bot@kernel.org
To: "Paul Sajna" <sajattack@postmarketos.org>
Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
robh@kernel.org, conor+dt@kernel.org, lee@kernel.org
Subject: Re: [PATCH v7 3/4] drivers: leds: aw2013: Leverage C99 for-loops
Date: Sat, 14 Nov 2026 23:00:03 +0000 [thread overview]
Message-ID: <sashiko-outbox-215079@kernel.org> (raw)
In-Reply-To: <20261114-aw2013-aw20xx-rename-v7-3-ea5a3113a479@postmarketos.org>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] leds: aw2013: commit subject uses drivers: leds: prefix instead
of leds:
--
commit dd420770c3e97b4e4988e32c3e735789959ed94e
Author: Paul Sajna <sajattack@postmarketos.org>
drivers: leds: aw2013: Leverage C99 for-loops
This commit moves loop counter declarations into the for-loop headers in
aw2013_chip_init() and aw2013_chip_in_use().
> drivers: leds: aw2013: Leverage C99 for-loops
[Severity: Low]
This isn't a bug, but LED subsystem commit subjects use the "leds:
<driver>: <Capitalized description>" format, so this should use the
"leds: aw2013:" prefix instead of "drivers: leds: aw2013:".
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261114-aw2013-aw20xx-rename-v7-0-ea5a3113a479@postmarketos.org?part=3
next prev parent reply other threads:[~2026-11-14 23:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-14 22:55 [PATCH v7 0/4] leds: aw2013: Add AW2027 support Paul Sajna
2026-11-14 22:55 ` [PATCH v7 1/4] dt-bindings: leds: aw2013: Add awinic,aw2027 compatible Paul Sajna
2026-11-14 22:55 ` [PATCH v7 2/4] leds: aw2013: Use dev_err_probe Paul Sajna
2026-11-14 22:55 ` [PATCH v7 3/4] drivers: leds: aw2013: Leverage C99 for-loops Paul Sajna
2026-11-14 23:00 ` sashiko-bot [this message]
2026-11-14 23:13 ` Paul Sajna
2026-11-14 22:55 ` [PATCH v7 4/4] leds: aw2013: Add AW2027 support Paul Sajna
2026-11-14 23:20 ` sashiko-bot
2026-11-14 23:26 ` Paul Sajna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-215079@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sajattack@postmarketos.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox