Re: [PATCH net-next v20 01/15] net: phylink: keep and use MAC supported_interfaces in phylink struct

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] net: phylink: use pl->supported_interfaces in
  phylink_create_sfp_cage_port()
--

commit 93205d49f980ea49e825ec43738fa0a2070e098a
Author: Christian Marangi <ansuelsmth@gmail.com>

net: phylink: keep and use MAC supported_interfaces in phylink struct

This commit copies supported_interfaces from phylink_config into struct
phylink and updates phylink to read from the internal copy in preparation
for dynamic PCS handling.

> diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
> index e885da1c28311..6c339b25926cc 100644
> --- a/drivers/net/phy/phylink.c
> +++ b/drivers/net/phy/phylink.c

[ ... ]

> @@ -4155,7 +4163,7 @@ static int phylink_sfp_connect_phy(void *upstream, struct phy_device *phy)
>  
>  	/* Set the PHY's host supported interfaces */
>  	phy_interface_and(phy->host_interfaces, phylink_sfp_interfaces,
> -			  pl->config->supported_interfaces);
> +			  pl->supported_interfaces);
>  
>  	phy_set_upstream_port(phy, pl->sfp_cage_port);
>  

[Severity: Low]
Should phylink_create_sfp_cage_port() also use pl->supported_interfaces
when populating pl->sfp_cage_port->interfaces?

drivers/net/phy/phylink.c:phylink_create_sfp_cage_port() {
    ...
	phy_interface_and(port->interfaces, pl->config->supported_interfaces,
			  phylink_sfp_interfaces);
	phy_port_update_supported(port);
    ...
}

When pl->supported_interfaces is later updated from attached PCS
instances, leaving phylink_create_sfp_cage_port() on
pl->config->supported_interfaces causes pl->sfp_cage_port->interfaces and
the downstream SFP module phy_port supported link modes in
phylink_add_sfp_mod_port() to omit PCS-supported SFP interfaces.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261114104426.235620-1-ansuelsmth@gmail.com?part=1