Re: [PATCH v2 4/7] dt-bindings: power: supply: axp20x-usb-power: Add the AXP2101

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dt-bindings: power: supply: piling per-compatible if-then onto
  axp20x schema
--

commit b91180032c14c7d6f98055be9d7c8629fe0f89d7
Author: Olivier Louvignes <olivier@mgcrea.io>

dt-bindings: power: supply: axp20x-usb-power-supply: Add the AXP2101

This commit adds the x-powers,axp2101-usb-power-supply compatible string
and its supported input-current-limit-microamp values to the AXP20x USB
power supply Device Tree binding schema.

> diff --git a/Documentation/devicetree/bindings/power/supply/x-powers,axp20x-usb-power-supply.yaml b/Documentation/devicetree/bindings/power/supply/x-powers,axp20x-usb-power-supply.yaml
> index 2ec036405ae47..439b3ea6a7f5b 100644
> --- a/Documentation/devicetree/bindings/power/supply/x-powers,axp20x-usb-power-supply.yaml
> +++ b/Documentation/devicetree/bindings/power/supply/x-powers,axp20x-usb-power-supply.yaml
> @@ -25,6 +25,7 @@ properties:
>            - x-powers,axp223-usb-power-supply
>            - x-powers,axp717-usb-power-supply
>            - x-powers,axp813-usb-power-supply
> +          - x-powers,axp2101-usb-power-supply
>        - items:
>            - const: x-powers,axp803-usb-power-supply
>            - const: x-powers,axp813-usb-power-supply
> @@ -101,4 +102,15 @@ allOf:
>            enum: [100000, 500000, 900000, 1500000, 2000000, 2500000,
>                   3000000, 3500000, 4000000]
>  
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - x-powers,axp2101-usb-power-supply
> +    then:
> +      properties:
> +        input-current-limit-microamp:
> +          enum: [100000, 500000, 900000, 1000000, 1500000, 2000000]
> +
>  additionalProperties: false

[Severity: Low]
This schema only defines compatible and input-current-limit-microamp, yet
allOf now has six separate per-compatible if-then blocks because almost
every AXP variant supports a different set of current limits.  Should this
binding be split into separate schema documents rather than piling on more
per-variant conditionals?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261115171150.64431-1-olivier@mgcrea.io?part=4