Re: [PATCH net-next v5 1/6] net: xilinx: axienet: Introduce axienet_config for MAC-specific ops

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] net: xilinx: axienet: axienet_probe() fails on software-node
  devices
--

commit 783576cb6315304b083793b1e0a0ea48b15baa81
Author: Suraj Gupta <suraj.gupta2@amd.com>

net: xilinx: axienet: Introduce axienet_config for MAC-specific ops

This commit introduces struct axienet_config to abstract MAC-specific
capabilities and callbacks, populating it from axienet_of_match and
converting the shared paths to use it.

> diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> index 7e83c4b5f1931..125ad3dbf6aa9 100644
> --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c

[ ... ]

> @@ -2898,27 +3046,13 @@ static int axienet_probe(struct platform_device *pdev)
>  	seqcount_mutex_init(&lp->hw_stats_seqcount, &lp->stats_lock);
>  	INIT_DEFERRABLE_WORK(&lp->stats_work, axienet_refresh_stats);
>  
> -	lp->axi_clk = devm_clk_get_optional_enabled(&pdev->dev,
> -						    "s_axi_lite_clk");
> -	if (!lp->axi_clk) {
> -		/* For backward compatibility, if named AXI clock is not present,
> -		 * treat the first clock specified as the AXI clock.
> -		 */
> -		lp->axi_clk = devm_clk_get_optional_enabled(&pdev->dev, NULL);
> -	}
> -	if (IS_ERR(lp->axi_clk))
> -		return dev_err_probe(&pdev->dev, PTR_ERR(lp->axi_clk),
> -				     "could not get AXI clock\n");
> -
> -	lp->misc_clks[0].id = "axis_clk";
> -	lp->misc_clks[1].id = "ref_clk";
> -	lp->misc_clks[2].id = "mgt_clk";
> +	lp->axienet_config = device_get_match_data(&pdev->dev);
> +	if (!lp->axienet_config)
> +		return -ENODEV;

[Severity: High]
Does this break probing for platform devices matched by driver name and
backed by a software_node, such as those registered after commits
f5185ec79dac ("net: axienet: use device_property and fwnode APIs for
probe-time config") and 418149559ef3 ("net: axienet: add a MODULE_ALIAS
for platform instantiation")?

software_node_ops does not implement .device_get_match_data and
axienet_driver has no id_table, so device_get_match_data() returns NULL on
non-OF platform devices and axienet_probe() now fails with -ENODEV instead
of defaulting to axienet_1g_config.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261114182947.2908628-1-suraj.gupta2@amd.com?part=1