From: sashiko-bot@kernel.org
To: "Akshat Singh" <automobilehacks@gmail.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 3/3] mips: dts: Connect the EcoNet EN751221 intc to IP2-IP6
Date: Sun, 15 Nov 2026 19:32:32 +0000 [thread overview]
Message-ID: <sashiko-outbox-215748@kernel.org> (raw)
In-Reply-To: <20261115-en751221-intc-all-lines-v1-3-dc03a40f47f0@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] mips: dts: econet: missing Fixes trailer for EN751221 intc
interrupt lines fix
--
commit ef45b82519d1615a5175bd08b37ea85f1395050e
Author: Akshat Singh <automobilehacks@gmail.com>
> mips: dts: Connect the EcoNet EN751221 intc to IP2-IP6
>
> The interrupt controller presents the number of the pending interrupt
> plus one, in binary, on the CPU interrupt lines IP2-IP7. Without VEIC,
> chaining it to IP2 alone leaves the odd-numbered interrupts, such as the
> QDMA, xHCI and the first PCIe port, waiting for an even-numbered one to
> run the handler.
>
> List IP2-IP6. IP7 is left out: the CPU can also signal its own timer on
> it, and only hwirq 31, which is unused, needs it.
>
> Signed-off-by: Akshat Singh <automobilehacks@gmail.com>
[Severity: Low]
This fixes interrupt delivery for odd-numbered interrupts on the EN751221
in non-VEIC mode. Should this include:
Fixes: 0ec488700972 ("mips: dts: Add EcoNet DTS with EN751221 and SmartFiber XP8421-B board")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261115-en751221-intc-all-lines-v1-0-dc03a40f47f0@gmail.com?part=3
prev parent reply other threads:[~2026-11-15 19:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-15 19:26 [PATCH 0/3] irqchip/econet-en751221: Deliver odd interrupts without VEIC Akshat Singh via B4 Relay
2026-11-15 19:26 ` [PATCH 1/3] dt-bindings: interrupt-controller: econet,en751221-intc: Allow up to 6 parent interrupts Akshat Singh via B4 Relay
2026-11-15 19:26 ` [PATCH 2/3] irqchip/econet-en751221: Chain the handler to all " Akshat Singh via B4 Relay
2026-11-15 19:41 ` sashiko-bot
2026-11-15 19:26 ` [PATCH 3/3] mips: dts: Connect the EcoNet EN751221 intc to IP2-IP6 Akshat Singh via B4 Relay
2026-11-15 19:32 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-215748@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=automobilehacks@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox