Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Kyrie Wu" <kyrie.wu@mediatek.com>, devicetree@vger.kernel.org
Cc: robh@kernel.org, conor+dt@kernel.org, media-ci@linuxtv.org
Subject: Re: [PATCH v19 13/13] media: mediatek: jpeg: add jpeg smmu sid setting
Date: Mon, 16 Nov 2026 02:04:38 +0000	[thread overview]
Message-ID: <sashiko-outbox-216063@kernel.org> (raw)
In-Reply-To: <20261116013402.1273016-14-kyrie.wu@mediatek.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] media: mediatek: jpeg: broken parent bookkeeping on child probe
  failure
--

commit 2fd151988985bb81b93a21e0a51263106e01c671
Author: Kyrie Wu <kyrie.wu@mediatek.com>

media: mediatek: jpeg: add jpeg smmu sid setting

This commit configures the JPEG decoder and encoder SMMU stream IDs via the
mediatek,smmu-config syscon on MT8196 and initializes the SMMU regmap in the
component hardware probe functions before registering each core with the
parent device.

> diff --git a/drivers/media/platform/mediatek/jpeg/mtk_jpeg_dec_hw.c b/drivers/media/platform/mediatek/jpeg/mtk_jpeg_dec_hw.c
> index 6b636ec63434a..508ed4ff53695 100644
> --- a/drivers/media/platform/mediatek/jpeg/mtk_jpeg_dec_hw.c
> +++ b/drivers/media/platform/mediatek/jpeg/mtk_jpeg_dec_hw.c
> @@ -613,6 +613,25 @@ static int mtk_jpegdec_hw_init_irq(struct mtk_jpegdec_comp_dev *dev)
>  	return 0;
>  }
>  
> +static int mtk_jpegdec_smmu_init(struct mtk_jpegdec_comp_dev *dev)
> +{
> +	struct mtk_jpeg_dev *master_dev = dev->master_dev;
> +
> +	if (!master_dev->variant->support_smmu)
> +		return 0;
> +
> +	dev->smmu_regmap =
> +		syscon_regmap_lookup_by_phandle(dev->plat_dev->dev.of_node,
> +						"mediatek,smmu-config");
> +	if (IS_ERR(dev->smmu_regmap)) {
> +		return dev_err_probe(dev->dev, PTR_ERR(dev->smmu_regmap),
> +				     "mmap smmu_base failed(%pe)\n",
> +				     dev->smmu_regmap);
> +	}
> +
> +	return 0;
> +}
> +
>  static int mtk_jpegdec_hw_probe(struct platform_device *pdev)
>  {
>  	struct mtk_jpegdec_clk *jpegdec_clk;
> @@ -660,10 +679,15 @@ static int mtk_jpegdec_hw_probe(struct platform_device *pdev)
>  		return dev_err_probe(&pdev->dev, ret,
>  				     "Failed to register JPEGDEC irq handler.\n");
>  
> +	dev->master_dev = master_dev;
> +
> +	ret = mtk_jpegdec_smmu_init(dev);
> +	if (ret)
> +		return ret;
> +
>  	i = atomic_add_return(1, &master_dev->hw_index) - 1;
>  	master_dev->dec_hw_dev[i] = dev;
>  	master_dev->reg_decbase[i] = dev->reg_base;
> -	dev->master_dev = master_dev;
>  
>  	platform_set_drvdata(pdev, dev);
>  	pm_runtime_enable(&pdev->dev);
> diff --git a/drivers/media/platform/mediatek/jpeg/mtk_jpeg_enc_hw.c b/drivers/media/platform/mediatek/jpeg/mtk_jpeg_enc_hw.c
> index c2de272d71a34..8830480a4391e 100644
> --- a/drivers/media/platform/mediatek/jpeg/mtk_jpeg_enc_hw.c
> +++ b/drivers/media/platform/mediatek/jpeg/mtk_jpeg_enc_hw.c
> @@ -338,6 +338,25 @@ static int mtk_jpegenc_hw_init_irq(struct mtk_jpegenc_comp_dev *dev)
>  	return 0;
>  }
>  
> +static int mtk_jpegenc_smmu_init(struct mtk_jpegenc_comp_dev *dev)
> +{
> +	struct mtk_jpeg_dev *master_dev = dev->master_dev;
> +
> +	if (!master_dev->variant->support_smmu)
> +		return 0;
> +
> +	dev->smmu_regmap =
> +		syscon_regmap_lookup_by_phandle(dev->plat_dev->dev.of_node,
> +						"mediatek,smmu-config");
> +	if (IS_ERR(dev->smmu_regmap)) {
> +		return dev_err_probe(dev->dev, PTR_ERR(dev->smmu_regmap),
> +				     "mmap smmu_base failed(%pe)\n",
> +				     dev->smmu_regmap);
> +	}
> +
> +	return 0;
> +}
> +
>  static int mtk_jpegenc_hw_probe(struct platform_device *pdev)
>  {
>  	struct mtk_jpegenc_clk *jpegenc_clk;
> @@ -383,10 +402,15 @@ static int mtk_jpegenc_hw_probe(struct platform_device *pdev)
>  	if (ret)
>  		return ret;
>  
> +	dev->master_dev = master_dev;
> +
> +	ret = mtk_jpegenc_smmu_init(dev);
> +	if (ret)
> +		return ret;
> +
>  	i = atomic_add_return(1, &master_dev->hw_index) - 1;
>  	master_dev->enc_hw_dev[i] = dev;
>  	master_dev->reg_encbase[i] = dev->reg_base;
> -	dev->master_dev = master_dev;
>  
>  	platform_set_drvdata(pdev, dev);
>  	pm_runtime_enable(&pdev->dev);

[Severity: High]
Can returning early when mtk_jpegdec_smmu_init() or mtk_jpegenc_smmu_init()
fails or defers cause a NULL pointer dereference in mtk_jpegdec_get_hw() and
mtk_jpegenc_get_hw()?

In mtk_jpeg_probe(), jpeg->max_hw_count is set to the total number of child
DT nodes and the video device is registered regardless of whether each child
probe succeeded.  When a child probe fails or defers before reserving
hw_index, its slot in master_dev->dec_hw_dev[] or master_dev->enc_hw_dev[]
remains NULL, and mtk_jpegdec_get_hw() and mtk_jpegenc_get_hw() iterate up
to jpeg->max_hw_count without checking comp_jpeg for NULL:

drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c:mtk_jpegdec_get_hw() {
    ...
	for (i = 0; i < jpeg->max_hw_count; i++) {
		comp_jpeg = jpeg->dec_hw_dev[i];
		if (comp_jpeg->hw_state == MTK_JPEG_HW_IDLE) {
    ...
}

In addition, mtk_jpeg_probe() calls devm_of_platform_populate() before
initializing jpeg->max_hw_count and resetting jpeg->hw_index to 0:

drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c:mtk_jpeg_probe() {
    ...
	ret = devm_of_platform_populate(&pdev->dev);
	if (ret) {
		v4l2_err(&jpeg->v4l2_dev, "Master of platform populate failed.");
		return -EINVAL;
	}

	if (!jpeg->variant->multi_core) {
		...
	} else {
		init_waitqueue_head(&jpeg->hw_wq);

		for_each_child_of_node(pdev->dev.of_node, child)
			num_child++;

		jpeg->max_hw_count = num_child;
		atomic_set(&jpeg->hw_index, 0);
    ...
}

If one child probes synchronously inside devm_of_platform_populate() and
another defers in mtk_jpegdec_smmu_init() or mtk_jpegenc_smmu_init(),
atomic_set(&jpeg->hw_index, 0) resets hw_index to 0, so the deferred child's
later re-probe overwrites slot 0 and leaves slot 1 NULL.

Finally, when probe succeeds, master_dev->dec_hw_dev[i] and
master_dev->enc_hw_dev[i] are published with dev->hw_state already set to
MTK_JPEG_HW_IDLE without holding master_dev->hw_lock and before
platform_set_drvdata() and pm_runtime_enable() run, allowing a concurrent
worker to select hw_id = i and call pm_runtime_resume_and_get() before the
child device is ready.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261116013402.1273016-1-kyrie.wu@mediatek.com?part=13

      reply	other threads:[~2026-11-16  2:04 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16  1:33 [PATCH v19 00/13] media: mediatek: jpeg: add MT8196 JPEG support Kyrie Wu
2026-11-16  1:33 ` [PATCH v19 01/13] media: mediatek: jpeg: fix jpeg cores' amounts setting Kyrie Wu
2026-11-16  1:48   ` sashiko-bot
2026-11-16  1:33 ` [PATCH v19 02/13] media: mediatek: jpeg: fix jpeg buffer payload size setting Kyrie Wu
2026-11-16  1:33 ` [PATCH v19 03/13] media: mediatek: jpeg: fix buffer structure size and layout Kyrie Wu
2026-11-16  1:33 ` [PATCH v19 04/13] media: mediatek: jpeg: Fix buffer completion on multi-core streaming stop Kyrie Wu
2026-11-16  1:33 ` [PATCH v19 05/13] media: mediatek: jpeg: Fix multi-core clk suspend and resume setting Kyrie Wu
2026-11-16  2:03   ` sashiko-bot
2026-11-16  1:33 ` [PATCH v19 06/13] media: mediatek: jpeg: fix buffer state update timing Kyrie Wu
2026-11-16  1:52   ` sashiko-bot
2026-11-16  1:33 ` [PATCH v19 07/13] media: mediatek: jpeg: fix resolution change event handling in decoder Kyrie Wu
2026-11-16  1:55   ` sashiko-bot
2026-11-16  1:33 ` [PATCH v19 08/13] media: mediatek: jpeg: fix remove buffer removal timing for multi-core Kyrie Wu
2026-11-16  1:33 ` [PATCH v19 09/13] dt-bindings: soc: mediatek: Add MT8196 JPEG SMMU Kyrie Wu
2026-11-16  1:52   ` sashiko-bot
2026-11-16  1:33 ` [PATCH v19 10/13] media: dt-bindings: mediatek,jpeg: Add mediatek, mt8196-jpgdec compatible Kyrie Wu
2026-11-16  1:33 ` [PATCH v19 11/13] media: dt-bindings: mediatek,jpeg: Add mediatek, mt8196-jpgenc compatible Kyrie Wu
2026-11-16  1:33 ` [PATCH v19 12/13] media: mediatek: jpeg: add jpeg compatible Kyrie Wu
2026-11-16  2:04   ` sashiko-bot
2026-11-16  1:33 ` [PATCH v19 13/13] media: mediatek: jpeg: add jpeg smmu sid setting Kyrie Wu
2026-11-16  2:04   ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-216063@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kyrie.wu@mediatek.com \
    --cc=media-ci@linuxtv.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox