Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Ishu Brar" <patches@brar.si>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v5 1/2] dt-bindings: interconnect: qcom: Add SM7250 RPMh NoC
Date: Mon, 16 Nov 2026 06:51:17 +0000	[thread overview]
Message-ID: <sashiko-outbox-216335@kernel.org> (raw)
In-Reply-To: <20261116-icc-sm7250-v5-1-506be082a3c5@brar.si>

Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Medium] dt-bindings: interconnect: qcom: sm7250-rpmh: invalid child
  node modeling
- [Medium] dt-bindings: interconnect: qcom: sm7250-rpmh: clocks
  forbidden on aggre2-noc
--

commit b308f53251bfcc5ecbf2fb5f677aee7859d07704
Author: Ishu Brar <patches@brar.si>

dt-bindings: interconnect: qcom: Add SM7250 RPMh NoC

This commit adds the Device Tree binding schema and interconnect ID header
for the Qualcomm SM7250 RPMh Network-On-Chip interconnect providers.

> diff --git a/Documentation/devicetree/bindings/interconnect/qcom,sm7250-rpmh.yaml b/Documentation/devicetree/bindings/interconnect/qcom,sm7250-rpmh.yaml
> new file mode 100644
> index 0000000000000..8e729d78cce40
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interconnect/qcom,sm7250-rpmh.yaml
> @@ -0,0 +1,104 @@
[ ... ]
> +  clocks:
> +    items:
> +      - description: aggre UFS PHY AXI clock
> +      - description: aggre USB3 PRIM AXI clock
> +
> +  interconnect:
> +    type: object
> +    description:
> +      The interconnect providers do not have a separate QoS register space,
> +      but share parent's space.
> +
> +    allOf:
> +      - $ref: qcom,rpmh-common.yaml#
> +
> +    properties:
> +      compatible:
> +        enum:
> +          - qcom,sm7250-compute-noc
> +          - qcom,sm7250-mc-virt
> +          - qcom,sm7250-qup-virt
> +
> +    required:
> +      - compatible
> +
> +    unevaluatedProperties: false

[Severity: Medium]
Should qcom,sm7250-mc-virt and qcom,sm7250-qup-virt be top-level compatibles
with reg: false instead of child nodes under the interconnect property?

Unlike qcom,sm7250-compute-noc, which shares its parent's MMIO space for NPU
QoS ports, mc-virt and qup-virt are purely virtual BCM-voting providers with
no QoS registers at all.

In addition, defining this child node as a fixed property named interconnect
at the top level prevents a parent NoC node from having more than one child
interconnect node, and allows child interconnect nodes under any of the eight
parent NoC compatibles rather than restricting them in allOf to the parent
NoC whose register space is actually shared.

> +
> +required:
> +  - compatible
> +  - reg
> +
> +allOf:
> +  - $ref: qcom,rpmh-common.yaml#
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: qcom,sm7250-aggre1-noc
> +    then:
> +      required:
> +        - clocks
> +    else:
> +      properties:
> +        clocks: false

[Severity: Medium]
As reported by Krzysztof Kozlowski on v3 [1], does qcom,sm7250-aggre2-noc
also need a clocks property for the RPMH CC IPA clock?

In include/dt-bindings/interconnect/qcom,sm7250-rpmh.h, MASTER_IPA belongs to
aggre2-noc:

include/dt-bindings/interconnect/qcom,sm7250-rpmh.h:
#define MASTER_A2NOC_CFG		0
#define MASTER_QDSS_BAM			1
#define MASTER_QUP_0			2
#define MASTER_CRYPTO_CORE_0		3
#define MASTER_IPA			4

Setting clocks: false for all compatibles other than qcom,sm7250-aggre1-noc
prevents Device Tree from supplying the IPA clock needed to access the IPA
QoS registers in aggre2-noc.

[1] https://lore.kernel.org/r/20261027-tangible-steadfast-serval-caccf3@quoll

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-icc-sm7250-v5-0-506be082a3c5@brar.si?part=1

  reply	other threads:[~2026-11-16  6:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16  6:27 [PATCH v5 0/2] interconnect: qcom: Add SM7250 interconnect provider Ishu Brar via B4 Relay
2026-11-16  6:28 ` [PATCH v5 1/2] dt-bindings: interconnect: qcom: Add SM7250 RPMh NoC Ishu Brar via B4 Relay
2026-11-16  6:51   ` sashiko-bot [this message]
2026-11-16  6:28 ` [PATCH v5 2/2] interconnect: qcom: Add SM7250 interconnect provider driver Ishu Brar via B4 Relay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-216335@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=patches@brar.si \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox