From: sashiko-bot@kernel.org
To: "Taniya Das" <taniya.das@oss.qualcomm.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: pwm: qcom: add Shikra PWM controller
Date: Mon, 16 Nov 2026 07:22:14 +0000 [thread overview]
Message-ID: <sashiko-outbox-216406@kernel.org> (raw)
In-Reply-To: <20261116-pwm_qcom_shikra-v1-1-67ee4553adc5@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Low] dt-bindings: pwm: qcom: ranges property out of canonical order
- [Low] dt-bindings: pwm: qcom: unused pwm node label in binding example
--
commit e6638c1381c339afe2578e824d79ad21eb5519c9
Author: Taniya Das <taniya.das@oss.qualcomm.com>
dt-bindings: pwm: qcom: add Shikra PWM controller
This commit adds the Device Tree binding schema for the Qualcomm Shikra
PWM controller and its per-frame channel child nodes.
> diff --git a/Documentation/devicetree/bindings/pwm/qcom,shikra-pwm.yaml b/Documentation/devicetree/bindings/pwm/qcom,shikra-pwm.yaml
> new file mode 100644
> index 0000000000000..d7f2bdab68f68
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pwm/qcom,shikra-pwm.yaml
[ ... ]
> +properties:
> + compatible:
> + const: qcom,shikra-pwm
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + items:
> + - description: AHB bus clock for the PWM block.
> + - description: Gate clock shared by every frame (pwm_core).
> +
> + clock-names:
> + items:
> + - const: ahb
> + - const: core
> +
> + "#pwm-cells":
> + const: 3
> +
> + "#address-cells":
> + const: 2
> +
> + "#size-cells":
> + const: 2
> +
> + ranges: true
[ ... ]
> +required:
> + - compatible
> + - reg
> + - clocks
> + - clock-names
> + - "#pwm-cells"
> + - "#address-cells"
> + - "#size-cells"
> + - ranges
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/qcom,shikra-gcc.h>
> +
> + / {
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + pwm: pwm@4700000 {
[Severity: Low]
Should the unused pwm label on pwm@4700000 be dropped? Because &pwm is
never referenced in the example, scripts/dtc/dt-check-style --mode=strict
reports an [unused-labels] warning.
> + compatible = "qcom,shikra-pwm";
> + reg = <0x0 0x04700000 0x0 0x10>;
> + clocks = <&gcc GCC_PDM_AHB_CLK>, <&gcc GCC_PWM0_XO512_CLK>;
> + clock-names = "ahb", "core";
> + assigned-clocks = <&gcc GCC_PWM0_XO512_CLK>;
> + assigned-clock-rates = <9600000>;
> + #pwm-cells = <3>;
> + #address-cells = <2>;
> + #size-cells = <2>;
> + ranges;
[Severity: Low]
Should ranges be placed immediately after reg in the pwm@4700000 example
node, properties, and required? Putting ranges after #size-cells
deviates from the canonical DT property ordering and causes
scripts/dtc/dt-check-style --mode=strict to report a [property-order]
warning.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-pwm_qcom_shikra-v1-0-67ee4553adc5@oss.qualcomm.com?part=1
next prev parent reply other threads:[~2026-11-16 7:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 6:59 [PATCH 0/3] pwm: qcom: add Shikra PWM controller Taniya Das
2026-11-16 6:59 ` [PATCH 1/3] dt-bindings: " Taniya Das
2026-11-16 7:22 ` sashiko-bot [this message]
2026-11-16 6:59 ` [PATCH 2/3] pwm: qcom: add Shikra PWM controller support Taniya Das
2026-11-16 6:59 ` [PATCH 3/3] arm64: dts: qcom: add Shikra PWM controller Taniya Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-216406@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=taniya.das@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox