Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Venkat Yadlapati" <venkat.yadlapati@yahoo.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v2 11/11] arm64: dts: qcom: Add Motorola Signature (vantage)
Date: Mon, 16 Nov 2026 09:16:38 +0000	[thread overview]
Message-ID: <sashiko-outbox-216598@kernel.org> (raw)
In-Reply-To: <20261116-molokai-soc-v2-11-9dc4dddc4e96@yahoo.com>

Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Medium] arm64: dts: qcom: vantage simple-framebuffer lacks clocks and
  power domains
- [Low] arm64: dts: qcom: gpio@b800 out of unit-address order in pmic@0
--

commit 06a3bd9d7180afacf80e722fa6af997381342626
Author: Venkat Yadlapati <venkat.yadlapati@yahoo.com>

arm64: dts: qcom: Add Motorola Signature (vantage)

This commit adds the devicetree for the Motorola Signature (vantage)
smartphone based on the Qualcomm Molokai (SM8845) SoC.

> diff --git a/arch/arm64/boot/dts/qcom/molokai-motorola-vantage.dts b/arch/arm64/boot/dts/qcom/molokai-motorola-vantage.dts
> new file mode 100644
> index 0000000000000..6d6648b8cddc6
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/molokai-motorola-vantage.dts
> @@ -0,0 +1,784 @@

[ ... ]

> +	chosen {
> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +		ranges;
> +
> +		framebuffer0: framebuffer@fc800000 {
> +			compatible = "simple-framebuffer";
> +			reg = <0x0 0xfc800000 0x0 0x2b00000>;
> +			width = <1264>;
> +			height = <2780>;
> +			stride = <(1264 * 4)>;
> +			format = "a8r8g8b8";
> +		};
> +	};

[Severity: Medium]
Does framebuffer0 need clocks and power-domains properties (or dispcc
disabled) to keep the bootloader-initialized display pipeline running?

In kaanapali.dtsi, gcc and dispcc are enabled by default while mdss is
disabled.  Without a consumer claiming GCC_DISP_HF_AXI_CLK, the dispcc
MDSS clocks, and DISP_CC_MDSS_CORE_GDSC, clk_disable_unused() and
genpd_power_off_unused() will gate the display clocks and collapse the
MDSS core GDSC during late initcalls, breaking simple-framebuffer
scanout.

[ ... ]

> +&spmi_bus0 {
> +	pmic@0 {
> +		compatible = "qcom,pmk8550", "qcom,spmi-pmic";
> +		reg = <0x0 SPMI_USID>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		pmk8550_pon: pon@1300 {
> +			compatible = "qcom,pmk8350-pon";
> +			reg = <0x1300>,
> +			      <0x800>;
> +			reg-names = "hlos",
> +				    "pbs";
> +
> +			pon_pwrkey: pwrkey {
> +				compatible = "qcom,pmk8350-pwrkey";
> +				interrupts = <0x0 0x13 0x7 IRQ_TYPE_EDGE_BOTH>;
> +				linux,code = <KEY_POWER>;
> +			};
> +
> +			pon_resin: resin {
> +				compatible = "qcom,pmk8350-resin";
> +				interrupts = <0x0 0x13 0x6 IRQ_TYPE_EDGE_BOTH>;
> +				linux,code = <KEY_VOLUMEDOWN>;
> +			};
> +		};
> +
> +		pmk8550_gpios: gpio@b800 {
> +			compatible = "qcom,pmk8550-gpio", "qcom,spmi-gpio";
> +			reg = <0xb800>;
> +			gpio-controller;
> +			gpio-ranges = <&pmk8550_gpios 0 0 6>;
> +			#gpio-cells = <2>;
> +			interrupt-controller;
> +			#interrupt-cells = <2>;
> +		};
> +
> +		pmk8550_rtc: rtc@6100 {

[Severity: Low]
This isn't a bug, but gpio@b800 is out of ascending unit-address order
within pmic@0 and should be placed after nvram@7100.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-molokai-soc-v2-0-9dc4dddc4e96@yahoo.com?part=11

      reply	other threads:[~2026-11-16  9:16 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16  7:39 [PATCH v2 00/11] Add support for the Qualcomm Molokai (SM8845) and the Motorola Signature Venkat Yadlapati via B4 Relay
2026-11-16  7:39 ` [PATCH v2 01/11] dt-bindings: arm: qcom,ids: Add SoC ID for SM8845 Venkat Yadlapati via B4 Relay
2026-11-16  7:40 ` [PATCH v2 02/11] soc: qcom: socinfo: Add SM8845 SoC ID Venkat Yadlapati via B4 Relay
2026-11-16  7:40 ` [PATCH v2 03/11] dt-bindings: interrupt-controller: qcom,pdc: Document Molokai PDC Venkat Yadlapati via B4 Relay
2026-11-16  7:40 ` [PATCH v2 04/11] soc: qcom: ubwc: Add config for Molokai Venkat Yadlapati via B4 Relay
2026-11-16  7:40 ` [PATCH v2 05/11] soc: qcom: pd-mapper: Add support " Venkat Yadlapati via B4 Relay
2026-11-16  7:40 ` [PATCH v2 06/11] dt-bindings: arm: qcom-soc: Extend pattern " Venkat Yadlapati via B4 Relay
2026-11-16  7:40 ` [PATCH v2 07/11] dt-bindings: arm: qcom: Document Molokai and the Motorola Signature Venkat Yadlapati via B4 Relay
2026-11-16  7:40 ` [PATCH v2 08/11] arm64: dts: qcom: kaanapali: Add the second DSI controller and PHY Venkat Yadlapati via B4 Relay
2026-11-16  7:40 ` [PATCH v2 09/11] arm64: dts: qcom: Add Molokai (SM8845) SoC dtsi Venkat Yadlapati via B4 Relay
2026-11-16  7:40 ` [PATCH v2 10/11] arm64: dts: qcom: molokai: Describe the Adreno 829 GPU Venkat Yadlapati via B4 Relay
2026-11-16  7:40 ` [PATCH v2 11/11] arm64: dts: qcom: Add Motorola Signature (vantage) Venkat Yadlapati via B4 Relay
2026-11-16  9:16   ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-216598@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=venkat.yadlapati@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox