Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Wolfram Sang" <wsa+renesas@sang-engineering.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH] arm64: dts: renesas: beacon: Increase sdhi speeds
Date: Mon, 16 Nov 2026 11:08:41 +0000	[thread overview]
Message-ID: <sashiko-outbox-216847@kernel.org> (raw)
In-Reply-To: <20261116104427.5152-2-wsa+renesas@sang-engineering.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] arm64: dts: renesas: beacon: HS400 enabled on r8a774a1 without
  SDHI quirks
--

commit b89b68011d07b5d887c10ae098b7d13e972848a1
Author: Adam Ford <aford173@gmail.com>

arm64: dts: renesas: beacon: Increase sdhi speeds

This commit enables UHS SDR50/SDR104 modes on sdhi2 for WiFi and HS400
mode on sdhi3 for the eMMC in the shared Beacon Renesom SOM device tree.

> diff --git a/arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi b/arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi
> index 8825131490420..8af2edaa690af 100644
> --- a/arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi
> +++ b/arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi

[ ... ]

> @@ -317,6 +320,7 @@ &sdhi3 {
>  	vqmmc-supply = <&reg_1p8v>;
>  	bus-width = <8>;
>  	mmc-hs200-1_8v;
> +	mmc-hs400-1_8v;
>  	no-sd;
>  	no-sdio;
>  	non-removable;

[Severity: High]
Does enabling mmc-hs400-1_8v here break eMMC HS400 transfers on
r8a774a1-beacon-rzg2m-kit with RZ/G2M ES1.3 or ES3.0?

beacon-renesom-som.dtsi is included by r8a774a1-beacon-rzg2m-kit.dts,
where sdhi3 has compatible "renesas,sdhi-r8a774a1",
"renesas,rcar-gen3-sdhi".  Unlike renesas,sdhi-r8a774b1 and
renesas,sdhi-r8a774e1, renesas_sdhi_internal_dmac_of_match[] has no
entry for renesas,sdhi-r8a774a1, so it falls back to
of_rcar_gen3_compatible with quirks set to NULL.  In sdhi_quirks_match[],
r8a774a1 only matches ES1.[012]:

drivers/mmc/host/renesas_sdhi_internal_dmac.c:
	{ .soc_id = "r8a774a1", .revision = "ES1.[012]", .data = &sdhi_quirks_4tap_nohs400 },
	{ .soc_id = "r8a7795", .revision = "ES2.0", .data = &sdhi_quirks_4tap },
	{ .soc_id = "r8a7796", .revision = "ES1.0", .data = &sdhi_quirks_4tap_nohs400_one_rx },
	{ .soc_id = "r8a7796", .revision = "ES1.[12]", .data = &sdhi_quirks_4tap_nohs400 },
	{ .soc_id = "r8a7796", .revision = "ES1.*", .data = &sdhi_quirks_r8a7796_es13 },

On r8a774a1 ES1.3 or ES3.0, HS400 is therefore enabled with quirks == NULL,
which programs 8-tap clock and SCC settings in renesas_sdhi_clk_update()
instead of 4-tap and skips bad-tap avoidance, manual tap correction, and
HS400 calibration table lookup for the onboard eMMC.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261116104427.5152-2-wsa+renesas@sang-engineering.com?part=1

      reply	other threads:[~2026-11-16 11:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 10:41 [PATCH] arm64: dts: renesas: beacon: Increase sdhi speeds Wolfram Sang
2026-11-16 11:08 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-216847@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox