Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Nabige Aala" <nabige.aala@oss.qualcomm.com>
Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
	dri-devel@lists.freedesktop.org, robh@kernel.org,
	conor+dt@kernel.org, vkoul@kernel.org, neil.armstrong@linaro.org,
	olteanv@gmail.com
Subject: Re: [PATCH v3 06/11] drm/msm/dpu: Fix DSI tear interrupts broken by adding INTF_9 and INTF_10
Date: Mon, 16 Nov 2026 13:29:42 +0000	[thread overview]
Message-ID: <sashiko-outbox-217078@kernel.org> (raw)
In-Reply-To: <20261116-nord-drv-dt-v3-6-e3d3bf0e2c49@oss.qualcomm.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] drm/msm/dpu: INTF_9 and INTF_10 added after use in Nord
  catalog
--

commit c5bdfb09c207793f3155b346b39bc8a0210ff8f2
Author: Nabige Aala <nabige.aala@oss.qualcomm.com>

> drm/msm/dpu: Fix DSI tear interrupts broken by adding INTF_9 and INTF_10
>
> Nord requires INTF_9 and INTF_10. However, enum dpu_hw_intr_reg relies
> on all MDP_INTFn_INTR entries being sequential — MDP_INTFn_INTR() macro
> computes the interrupt index as MDP_INTF0_INTR + (intf - INTF_0).
> Appending INTF_9 and INTF_10 after the tear entries would break this
> assumption, causing DSI tear interrupts on existing platforms to map to
> wrong interrupt registers.
>
> Fix this by inserting MDP_INTF9_INTR and MDP_INTF10_INTR before
> MDP_INTF1_TEAR_INTR and MDP_INTF2_TEAR_INTR, keeping the sequential
> block intact. Add the corresponding register entries to
> dpu_intr_set_7xxx and dpu_intr_set_13xx.
>
> Signed-off-by: Mahadevan P <mahadevan.p@oss.qualcomm.com>
> Signed-off-by: Nabige Aala <nabige.aala@oss.qualcomm.com>

[ ... ]

> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h
> index 0e65bf5ddc4a6..7eccb4d2c65ef 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h
> @@ -226,6 +226,8 @@ enum dpu_intf {
>  	INTF_6,
>  	INTF_7,
>  	INTF_8,
> +	INTF_9,
> +	INTF_10,
>  	INTF_MAX
>  };

[Severity: Medium]
Should this patch come before commit "drm/msm/dpu: Add support for DPU 12.1
on Nord"?

That earlier commit uses INTF_9 and INTF_10 in nord_intf[] before they are
defined here, which breaks the build and git bisect at that point in the
series.

Also, the commit subject and message describe this change as fixing a prior
addition of INTF_9 and INTF_10, whereas this patch introduces INTF_9,
INTF_10, MDP_INTF9_INTR, and MDP_INTF10_INTR for the first time.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-nord-drv-dt-v3-0-e3d3bf0e2c49@oss.qualcomm.com?part=6

  reply	other threads:[~2026-11-16 13:29 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 13:16 [PATCH v3 00/11] Add Qualcomm Nord display and eDP PHY support Nabige Aala
2026-11-16 13:16 ` [PATCH v3 01/11] dt-bindings: phy: qcom,edp-phy: Add DP PHY compatible for Nord Nabige Aala
2026-11-16 13:16 ` [PATCH v3 02/11] dt-bindings: display: msm: dp-controller: Document Nord DisplayPort Controller Nabige Aala
2026-11-16 13:31   ` sashiko-bot
2026-11-16 13:16 ` [PATCH v3 03/11] dt-bindings: display/msm: Document Nord MDSS Nabige Aala
2026-11-16 13:16 ` [PATCH v3 04/11] dt-bindings: display/msm: qcom,sm8650-dpu: Add Qualcomm Nord Soc Nabige Aala
2026-11-16 13:16 ` [PATCH v3 05/11] drm/msm/dpu: Add support for DPU 12.1 on Nord Nabige Aala
2026-11-16 13:16 ` [PATCH v3 06/11] drm/msm/dpu: Fix DSI tear interrupts broken by adding INTF_9 and INTF_10 Nabige Aala
2026-11-16 13:29   ` sashiko-bot [this message]
2026-11-16 13:16 ` [PATCH v3 07/11] drm/msm: mdss: Add support for MDSS on Nord Nabige Aala
2026-11-16 13:16 ` [PATCH v3 08/11] drm/msm/dp: Add support for DP controllers " Nabige Aala
2026-11-16 13:16 ` [PATCH v3 09/11] phy: qcom: edp: Generalize power-on path for per-SoC overrides Nabige Aala
2026-11-16 13:16 ` [PATCH v3 10/11] phy: qcom: edp: Add Nord-specific QSERDES COM register header Nabige Aala
2026-11-16 13:30   ` sashiko-bot
2026-11-16 13:16 ` [PATCH v3 11/11] phy: qcom: edp: Add Nord eDP/DP PHY support Nabige Aala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-217078@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=nabige.aala@oss.qualcomm.com \
    --cc=neil.armstrong@linaro.org \
    --cc=olteanv@gmail.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox