From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794835822; b=Zzio1uhychL+bpa5c+OZ5SiDXlZQLtd80gKcpIGB/cyaJcPIdpundyFwiUp7830jCh10 DRpOdpuIGrVlcj7a7SvABLPOeIuwiyLKpM3O5+hbxEqBoI8NUrSpZJhzdddnHz7comII7 D+V/0fBs66RhY+AWCcgGgmr6YFWX2eot7Bcgec46qbu7oZgw1fWSuiF8iNE1SB/B2PsjT P3Ad6e50zXny0z7NZt5FR+/xAmgFB7rOe5Pa2LDhYMywv5f1+AutB/I4p5Mc6dWhC6s04 HAGHUjY6N5Xp7DFe3aTv2cOlv9ttEuf1aoDwQJIlHQWK4uS9kOgrYWd85HISXSpyCyw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794835822; h=Received:DKIM-Signature:Message-ID:From:Subject:Reply-To:To:Cc: In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=NY7N2tubvcvARtBhqdjLt3ZsbtHPX+yB6//X0ZMhmUc=; b=oXXgtggw9/eMLP0TkBkOpmUfgHN5YGz/UMzlH1vq0GNlY8gXMmWgS8NJy9Uq/UdRgR7p SV/yDTGMPqIrSHxGS6Wp4BlcbeA9Do+IrO43USlwL8YCdrwP3HHbEIILTPUNvNy4sg4sK kES0JSJ5umlC8N3OjCr9QtazxmKXgwasRqDbehc/KupqPB8PE02y8qYEgkjJRJU6D+1x6 dEZyHbkgb/8102smGgslDpUVRRFYDaaKbv39T03zH93RdKTS+T5oVJErBWWwx5Mz2SV9A /j68KI3jq7xMzzurXE2x38zgi3PuiwAS3OOz8V+jfvu51GwgaQxcsA1SQPILJpItiuw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=HzJxLpqr; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC47F606A323 for ; Mon, 16 Nov 2026 13:30:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=HzJxLpqr Received: by smtp.kernel.org (Postfix) with ESMTPSA id E6F4D1F000C4; Mon, 16 Nov 2026 13:30:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794835822; bh=NY7N2tubvcvARtBhqdjLt3ZsbtHPX+yB6//X0ZMhmUc=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=HzJxLpqrze+Pbdpovk0B8ZZG7PltiXkwuecIehVqVhUb/xEzMjq5vGXGUH/cpIEIn EUCaRzMbGC98cIdlYXOIAUi4tHPOSs4STpfeB/RI4bxk42pcdHnb+415twOMvLkcc2 Kz+E6hnha2/Qj3UZrbP97MPJElG0xNI2DDiV/jnx2/XWtDK4CvJQQ8s7gqgJPFOUKw DBABeAEmSOkwlys6DI1fMcTTw8S6No1TlJn2iqkvQfBZBiZ7GxG1/Nw04EmT8SXF45 qjvtm1mQCxQUm+zkW/Vpb9Lh3FiORuMDvkXmicX5bpNl0YlCkI4zjYcUiHsPuQBaCh Dxbn2kodsIqYw== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v3 10/11] phy: qcom: edp: Add Nord-specific QSERDES COM register header Reply-To: sashiko-reviews@lists.linux.dev To: "Nabige Aala" Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, robh@kernel.org, conor+dt@kernel.org, vkoul@kernel.org, neil.armstrong@linaro.org, olteanv@gmail.com In-Reply-To: <20261116-nord-drv-dt-v3-10-e3d3bf0e2c49@oss.qualcomm.com> References: <20261116-nord-drv-dt-v3-0-e3d3bf0e2c49@oss.qualcomm.com> <20261116-nord-drv-dt-v3-10-e3d3bf0e2c49@oss.qualcomm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 16 Nov 2026 13:30:21 +0000 X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Low] phy: qcom: edp: duplicate QSERDES v6 COM register definitions in v8-nord header -- commit 6ae0c395ca0665ea9d8f96120d2aff620150f574 Author: Ritesh Kumar phy: qcom: edp: Add Nord-specific QSERDES COM register header This commit adds a header defining the QSERDES COM register offsets for the Nord DisplayPort QMP PHY. > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-qserdes-dp-com-v8-nord.h b= /drivers/phy/qualcomm/phy-qcom-qmp-qserdes-dp-com-v8-nord.h > new file mode 100644 > index 0000000000000..f38b48dae39e3 > --- /dev/null > +++ b/drivers/phy/qualcomm/phy-qcom-qmp-qserdes-dp-com-v8-nord.h > @@ -0,0 +1,51 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * Copyright (c) 2026 Qualcomm Innovation Center, Inc. All rights reserv= ed. > + */ > + > +#ifndef QCOM_PHY_QMP_QSERDES_DP_COM_V8_NORD_H_ > +#define QCOM_PHY_QMP_QSERDES_DP_COM_V8_NORD_H_ > + > +/* Nord DP QMP PHY - QSERDES COM registers (relocated from v8 base offse= ts) */ > +#define NORD_DP_QSERDES_COM_HSCLK_SEL_1 0x03c > +#define NORD_DP_QSERDES_COM_BIN_VCOCAL_CMP_CODE1_MODE0 0x058 > +#define NORD_DP_QSERDES_COM_BIN_VCOCAL_CMP_CODE2_MODE0 0x05c > +#define NORD_DP_QSERDES_COM_SSC_STEP_SIZE1_MODE0 0x060 > +#define NORD_DP_QSERDES_COM_SSC_STEP_SIZE2_MODE0 0x064 > +#define NORD_DP_QSERDES_COM_CP_CTRL_MODE0 0x070 > +#define NORD_DP_QSERDES_COM_PLL_RCTRL_MODE0 0x074 > +#define NORD_DP_QSERDES_COM_PLL_CCTRL_MODE0 0x078 > +#define NORD_DP_QSERDES_COM_CORECLK_DIV_MODE0 0x07c > +#define NORD_DP_QSERDES_COM_LOCK_CMP1_MODE0 0x080 > +#define NORD_DP_QSERDES_COM_LOCK_CMP2_MODE0 0x084 > +#define NORD_DP_QSERDES_COM_DEC_START_MODE0 0x088 > +#define NORD_DP_QSERDES_COM_DIV_FRAC_START1_MODE0 0x090 > +#define NORD_DP_QSERDES_COM_DIV_FRAC_START2_MODE0 0x094 > +#define NORD_DP_QSERDES_COM_DIV_FRAC_START3_MODE0 0x098 > +#define NORD_DP_QSERDES_COM_INTEGLOOP_GAIN0_MODE0 0x0a0 > +#define NORD_DP_QSERDES_COM_INTEGLOOP_GAIN1_MODE0 0x0a4 > +#define NORD_DP_QSERDES_COM_VCO_TUNE1_MODE0 0x0a8 > +#define NORD_DP_QSERDES_COM_VCO_TUNE2_MODE0 0x0ac > +#define NORD_DP_QSERDES_COM_BG_TIMER 0x0bc > +#define NORD_DP_QSERDES_COM_SSC_EN_CENTER 0x0c0 > +#define NORD_DP_QSERDES_COM_SSC_ADJ_PER1 0x0c4 > +#define NORD_DP_QSERDES_COM_SSC_PER1 0x0cc > +#define NORD_DP_QSERDES_COM_SSC_PER2 0x0d0 > +#define NORD_DP_QSERDES_COM_BIAS_EN_CLKBUFLR_EN 0x0dc > +#define NORD_DP_QSERDES_COM_CLK_ENABLE1 0x0e0 > +#define NORD_DP_QSERDES_COM_SYS_CLK_CTRL 0x0e4 > +#define NORD_DP_QSERDES_COM_SYSCLK_BUF_ENABLE 0x0e8 > +#define NORD_DP_QSERDES_COM_PLL_IVCO 0x0f4 > +#define NORD_DP_QSERDES_COM_SYSCLK_EN_SEL 0x110 > +#define NORD_DP_QSERDES_COM_RESETSM_CNTRL 0x118 > +#define NORD_DP_QSERDES_COM_LOCK_CMP_EN 0x120 > +#define NORD_DP_QSERDES_COM_VCO_TUNE_CTRL 0x13c > +#define NORD_DP_QSERDES_COM_VCO_TUNE_MAP 0x140 > +#define NORD_DP_QSERDES_COM_CLK_SELECT 0x164 > +#define NORD_DP_QSERDES_COM_CORE_CLK_EN 0x170 > +#define NORD_DP_QSERDES_COM_CMN_CONFIG_1 0x174 > +#define NORD_DP_QSERDES_COM_SVS_MODE_CLK_SEL 0x17c > +#define NORD_DP_QSERDES_COM_CMN_STATUS 0x1d0 > +#define NORD_DP_QSERDES_COM_C_READY_STATUS 0x1f8 [Severity: Low] Can Nord reuse the existing QSERDES_V6_COM_* definitions from drivers/phy/qualcomm/phy-qcom-qmp-qserdes-com-v6.h instead of introducing this SoC-specific header? All 40 NORD_DP_QSERDES_COM_* register offsets defined here are identical to the existing QSERDES_V6_COM_* definitions. Moreover, drivers/phy/qualcomm/phy-qcom-edp.c already includes phy-qcom-qmp-qserdes-com-v6.h and provides v6 COM helpers (such as qcom_edp_phy_power_on_v6(), qcom_edp_phy_com_resetsm_cntrl_v6(), and qcom_edp_com_bias_en_clkbuflr_v6()), and nord_usb3dpphy_cfg in drivers/phy/qualcomm/phy-qcom-qmp-combo.c already uses qmp_v6_dp_serdes_tbl with the QSERDES_V6_COM_* definitions. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261116-nord-drv-d= t-v3-0-e3d3bf0e2c49@oss.qualcomm.com?part=3D10