From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794836855; b=1VwfK4c21LqMjj8UfEfPQLTZiIhx6e33aPo4XnPEcvnLLfUhGOLoJgiF71YN4LDOGhC5 0fpFyXj++CCW+DQwbgKolxiG0dhP//RspooxJB9daBZps3n/ClfIETdvO9zN2Oq9woLwD au0nqM2Xn/Yfqj72wtQM62UZB5DY5uC5RGOWbbNzDPynw5kKELf7Q39a+TXwpj53LFtom lDZG4ht0t24Uhihs8D2ftbB96fN+UjEGQmozW37zwsFOEtG3i+cNcmeb3W3tomujRaQfv ZPMsULAsoouQWJl05hweiMx7eqFOqKmkDLjAtjBfQRT+PyzXfF0z+wQSjacXi9nWk8A== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794836855; h=Received:DKIM-Signature:Message-ID:From:Subject:Reply-To:To:Cc: In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=2winabVpaM77ETlKEcvhcxQYA9iyVxIX98gUumohxek=; b=v7gGDKv8Ew93Rnn4c6P4sc4X9d+PUcvO/ohv5CPa1Ol63Bb093t4/XMuNWISL4tLLrQC xR9eAPXVSblqNHQrusoqiHM6rSx1OJrqMrun+UoQ1sSt5XcLaerGZMdd/pQqb/hqdB5Z1 tjuJwOM//lP6exQVmic7UozfCEYJkopsMKu+fBSBF86J8tYG0v8j7bXQmzbUHnV/Slvgv +qcYYfGmKrkfCIrpg2Xf67lrzFWg+0BQuwMvMCdDd2dGok0StB892xgXmACVuW1FHrvcI T+X4/5VU2OgChrnTomdlzsEF/px++NXVVzzBKU+HKj/ebno6Y7TnABGa0rkTJRhEZJQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=E9I352bd; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED9AB606A330 for ; Mon, 16 Nov 2026 13:47:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=E9I352bd Received: by smtp.kernel.org (Postfix) with ESMTPSA id 565381F000C9; Mon, 16 Nov 2026 13:47:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794836854; bh=2winabVpaM77ETlKEcvhcxQYA9iyVxIX98gUumohxek=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=E9I352bdxOVGz1bbCSomh0jG1MPe2WyunjGCj/dqH5fLaRu4sJ2ebF1oWpDF1HBSo ybDaYXhniwOrLFGc4w0x+pvwo6zjzCgaMaVSIjkxsKZu0gvRtDZg/r9cttPJUnGpVq xGVZR/aU7i0HGAxnOeFdQwqBxc3zSr75OLOfhm4exw4CBbHmt2KUIV4oPlRb5P2eL+ 7T2v65oqKnpYMOFk+21Ko7rihtda0ppBK5gmyRCC6PM76+jSrXvkmOzKMSC4G9YoWp hN7a//mzblHnjVyrO19v2SFk0SdSSZKUWl6Ba0mbk4QRQoLRTyaboQN8sjtIbDfNtJ fS6fEjMCdWrFQ== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v3 05/11] drm/msm/dpu: Add support for DPU 12.1 on Nord Reply-To: sashiko-reviews@lists.linux.dev To: "Nabige Aala" Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, robh@kernel.org, conor+dt@kernel.org, vkoul@kernel.org, neil.armstrong@linaro.org, olteanv@gmail.com In-Reply-To: <20261116-nord-drv-dt-v3-5-e3d3bf0e2c49@oss.qualcomm.com> References: <20261116-nord-drv-dt-v3-0-e3d3bf0e2c49@oss.qualcomm.com> <20261116-nord-drv-dt-v3-5-e3d3bf0e2c49@oss.qualcomm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 16 Nov 2026 13:47:33 +0000 X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Thank you for your contribution! Sashiko AI review found 2 potential issues to consider: - [High] drm/msm/dpu: undeclared INTF_9 and INTF_10 in nord_intf break build - [Medium] drm/msm/dpu: wrong interrupt bit assignments for intf_6..intf_10 on Nord -- commit 26c8821f9a7d74ed713c34eb7d82f28a0037edd5 Author: Mahadevan P drm/msm/dpu: Add support for DPU 12.1 on Nord This commit adds the DPU 12.1 hardware catalog configuration and device tree match entry for the Qualcomm Nord SoC. > diff --git a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_12_1_nord.h b/driv= ers/gpu/drm/msm/disp/dpu1/catalog/dpu_12_1_nord.h > new file mode 100644 > index 0000000000000..333eccb5c603a > --- /dev/null > +++ b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_12_1_nord.h > @@ -0,0 +1,544 @@ [ ... ] > +static const struct dpu_intf_cfg nord_intf[] =3D { > + { > + .name =3D "intf_0", .id =3D INTF_0, > + .base =3D 0x34000, .len =3D 0x4bc, > + .type =3D INTF_DP, > + .controller_id =3D MSM_DP_CONTROLLER_0, > + .prog_fetch_lines_worst_case =3D 24, > + .intr_underrun =3D DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 24), > + .intr_vsync =3D DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 25), > + }, { > + .name =3D "intf_3", .id =3D INTF_3, > + .base =3D 0x37000, .len =3D 0x4bc, > + .type =3D INTF_DP, > + .controller_id =3D MSM_DP_CONTROLLER_0, > + .prog_fetch_lines_worst_case =3D 24, > + .intr_underrun =3D DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 30), > + .intr_vsync =3D DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 31), > + }, { > + .name =3D "intf_4", .id =3D INTF_4, > + .base =3D 0x38000, .len =3D 0x4bc, > + .type =3D INTF_DP, > + .controller_id =3D MSM_DP_CONTROLLER_1, > + .prog_fetch_lines_worst_case =3D 24, > + .intr_underrun =3D DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 20), > + .intr_vsync =3D DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 21), > + }, { > + .name =3D "intf_6", .id =3D INTF_6, > + .base =3D 0x3a000, .len =3D 0x4bc, > + .type =3D INTF_DP, > + .controller_id =3D MSM_DP_CONTROLLER_0, > + .prog_fetch_lines_worst_case =3D 24, > + .intr_underrun =3D DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 22), > + .intr_vsync =3D DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 23), > + }, { > + .name =3D "intf_7", .id =3D INTF_7, > + .base =3D 0x3b000, .len =3D 0x4bc, > + .type =3D INTF_DP, > + .controller_id =3D MSM_DP_CONTROLLER_0, > + .prog_fetch_lines_worst_case =3D 24, > + .intr_underrun =3D DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 0), > + .intr_vsync =3D DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 1), > + }, { > + .name =3D "intf_8", .id =3D INTF_8, > + .base =3D 0x3c000, .len =3D 0x4bc, > + .type =3D INTF_DP, > + .controller_id =3D MSM_DP_CONTROLLER_1, > + .prog_fetch_lines_worst_case =3D 24, > + .intr_underrun =3D DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 2), > + .intr_vsync =3D DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 3), > + }, { > + .name =3D "intf_9", .id =3D INTF_9, > + .base =3D 0x3d000, .len =3D 0x4bc, > + .type =3D INTF_DP, > + .controller_id =3D MSM_DP_CONTROLLER_1, > + .prog_fetch_lines_worst_case =3D 24, > + .intr_underrun =3D DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 4), > + .intr_vsync =3D DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 5), > + }, { > + .name =3D "intf_10", .id =3D INTF_10, > + .base =3D 0x3e000, .len =3D 0x4bc, > + .type =3D INTF_DP, > + .controller_id =3D MSM_DP_CONTROLLER_1, > + .prog_fetch_lines_worst_case =3D 24, > + .intr_underrun =3D DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 6), > + .intr_vsync =3D DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 7), > + }, > +}; [Severity: High] As reported by Dmitry Baryshkov on v1 [1], does referencing INTF_9 and INTF= _10 in nord_intf break the build at this commit? At this point in the series, enum dpu_intf only defines INTF_0 through INTF= _8, and enum dpu_hw_intr_reg and dpu_intr_set_7xxx lack MDP_INTF9_INTR and MDP_INTF10_INTR, so MDP_INTFn_INTR(intf->id) in dpu_hw_intr_init() also aliases MDP_INTF1_TEAR_INTR and MDP_INTF2_TEAR_INTR. These definitions are added later in the series by commit "drm/msm/dpu: Fix DSI tear interrupts broken by adding INTF_9 and INTF_10", which should be ordered before this patch to keep the series bisectable. [Severity: Medium] Are the intr_underrun and intr_vsync bit indices for intf_6 through intf_10= in nord_intf shifted onto the wrong interrupt bits? On DPU 12.x (such as glymur_intf in dpu_12_2_glymur.h), MDP_SSPP_TOP0_INTR bits 22 and 23 belong to INTF_5, while INTF_6 uses bits 16 and 17, INTF_7 u= ses bits 18 and 19, and INTF_8 uses bits 12 and 13. Because INTF_5 is omitted = on Nord, intf_6 appears to have been assigned INTF_5's bits (22 and 23) and intf_7 through intf_10 were sequentially assigned bits 0 through 7 in MDP_SSPP_TOP0_INTR2, which will cause vblank and underrun interrupts to nev= er fire and dpu_encoder_phys_vid_wait_for_tx_complete() to time out when any of these interfaces are used. [1] https://lore.kernel.org/r/bqoezyuyrjiawudbwxybvjpdun5f3fmhhzukdeg2holuc= 2mykq@oa5mhoylopz7 --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261116-nord-drv-d= t-v3-0-e3d3bf0e2c49@oss.qualcomm.com?part=3D5