Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: nhansp <nhan.094.vn@gmail.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: arm: samsung: Document greatlte board binding
Date: Mon, 16 Nov 2026 14:56:24 +0000	[thread overview]
Message-ID: <sashiko-outbox-217205@kernel.org> (raw)
In-Reply-To: <20261116-upstream-greatlte-dts-v1-1-768d49fb7d85@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] dt-bindings: arm: samsung: Signed-off-by uses handle instead of
  real name
--

commit 4517a49b2a0b8deb5681a06d92dd878703c2461c
Author: nhansp <nhan.094.vn@gmail.com>

> dt-bindings: arm: samsung: Document greatlte board binding
>
> Add a compatible for the Samsung Galaxy Note8 (SM-N950N), codenamed
> greatlte, which is based on the Exynos 8895 SoC.
>
> Signed-off-by: nhansp <nhan.094.vn@gmail.com>

[Severity: High]
The Author header and Signed-off-by trailer use a handle (nhansp) instead
of a full real human name, which does not meet the Developer's Certificate
of Origin requirements in Documentation/process/submitting-patches.rst.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-upstream-greatlte-dts-v1-0-768d49fb7d85@gmail.com?part=1

  reply	other threads:[~2026-11-16 14:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 14:50 [PATCH 0/2] Add support for Samsung Galaxy Note8 (SM-N950N) nhansp
2026-11-16 14:50 ` [PATCH 1/2] dt-bindings: arm: samsung: Document greatlte board binding nhansp
2026-11-16 14:56   ` sashiko-bot [this message]
2026-11-16 14:50 ` [PATCH 2/2] arm64: dts: exynos: Add initial support for Samsung Galaxy Note8 nhansp
2026-11-16 14:57   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-217205@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=nhan.094.vn@gmail.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox