Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Dinh Nguyen" <dinguyen@kernel.org>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCHv4 4/4] arm64: dts: socfpga: agilex5: add support for the ECC manager
Date: Mon, 16 Nov 2026 20:45:41 +0000	[thread overview]
Message-ID: <sashiko-outbox-217674@kernel.org> (raw)
In-Reply-To: <20261116202854.3087673-4-dinguyen@kernel.org>

Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Low] arm64: dts: agilex5: eccmgr node violates
  altr,socfpga-ecc-manager.yaml schema
- [Low] arm64: dts: agilex5: dtc W=1 unit_address_vs_reg warning on
  eccmgr node
--

commit 80980c0e21089f61a20d6226bf0f7f5a1d6f7334
Author: Dinh Nguyen <dinguyen@kernel.org>

arm64: dts: socfpga: agilex5: add support for the ECC manager

This commit adds the eccmgr node to the Agilex5 base dtsi along with child
nodes for OCRAM ECC and EMAC0/1/2 RX and TX ECC.

> diff --git a/arch/arm64/boot/dts/altera/socfpga_agilex5.dtsi b/arch/arm64/boot/dts/altera/socfpga_agilex5.dtsi
> index 161f3d4bbefe8..12d623d4b892e 100644
> --- a/arch/arm64/boot/dts/altera/socfpga_agilex5.dtsi
> +++ b/arch/arm64/boot/dts/altera/socfpga_agilex5.dtsi
> @@ -160,6 +160,75 @@ qspi_clk: qspi-clk {
>  		};
>  	};
>  
> +	eccmgr {
> +		compatible = "altr,socfpga-agilex5-ecc-manager",
> +			     "altr,socfpga-a10-ecc-manager";
> +		altr,sysmgr-syscon = <&sysmgr>;
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		interrupt-parent = <&intc>;
> +		interrupts = <GIC_SPI 15 IRQ_TYPE_LEVEL_HIGH>,
> +			     <GIC_SPI 241 IRQ_TYPE_LEVEL_HIGH>,
> +			     <GIC_SPI 95 IRQ_TYPE_EDGE_RISING>,
> +			     <GIC_SPI 120 IRQ_TYPE_EDGE_RISING>,
> +			     <GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>,
> +			     <GIC_SPI 9 IRQ_TYPE_LEVEL_HIGH>,
> +			     <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
> +		interrupt-names = "global_sbe", "global_dbe", "io96b0" , "io96b1",
> +				  "sdm_qspi_sbe", "sdm_qspi_dbe", "sdm_seu";

[Severity: Low]
Does the eccmgr node pass make dtbs_check against
Documentation/devicetree/bindings/edac/altr,socfpga-ecc-manager.yaml?

Matching "altr,socfpga-a10-ecc-manager" selects that schema, which does not
document "altr,socfpga-agilex5-ecc-manager", limits interrupts to at most 2
items instead of 7, and rejects interrupt-names because additionalProperties
is false.

> +		interrupt-controller;
> +		#interrupt-cells = <2>;
> +		ranges = <0 0 0 0xffffffff>;

[Severity: Low]
Does a non-empty ranges property on eccmgr without a unit address trigger a
dtc unit_address_vs_reg warning ("/eccmgr: node has a reg or ranges
property, but no unit name") when building DTBs with W=1?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261116202854.3087673-4-dinguyen@kernel.org?part=1

      reply	other threads:[~2026-11-16 20:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 20:28 [PATCHv4 1/4] EDAC/altera: use flag to differentiate 64-bit platforms Dinh Nguyen
2026-11-16 20:28 ` [PATCHv4 2/4] dt-bindings: edac: altera: agilex5: document new edac support Dinh Nguyen
2026-11-16 20:28 ` [PATCHv4 3/4] EDAC/altera: Add support for Agilex5 ECC manager Dinh Nguyen
2026-11-16 20:28 ` [PATCHv4 4/4] arm64: dts: socfpga: agilex5: add support for the " Dinh Nguyen
2026-11-16 20:45   ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-217674@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dinguyen@kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox