Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Daniel Carter" <yass27106@gmail.com>
Cc: linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
	robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v5 2/3] arm64: dts: qcom: add device tree for Asus Vivobook 16 X1607QA
Date: Mon, 16 Nov 2026 21:11:15 +0000	[thread overview]
Message-ID: <sashiko-outbox-217692@kernel.org> (raw)
In-Reply-To: <6fc5be59b56e42728e33595d5415441f@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] arm64: dts: qcom: x1607qa inherits 15.6-inch s15 eDP panel
  node
--

commit c3f535b7ac6cd47469ae3b65340861de92f7a5bb
Author: Daniel Carter <yass27106@gmail.com>

arm64: dts: qcom: add device tree for Asus Vivobook 16 X1607QA

This commit adds the device tree for the 16-inch Asus Vivobook 16 X1607QA
laptop based on the Qualcomm X1P-42-100 SoC, building on
x1-asus-vivobook-s15.dtsi.

> diff --git a/arch/arm64/boot/dts/qcom/x1p42100-asus-vivobook-16-x1607qa.dts b/arch/arm64/boot/dts/qcom/x1p42100-asus-vivobook-16-x1607qa.dts
> new file mode 100644
> index 0000000000000..3877809dcb33a
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/x1p42100-asus-vivobook-16-x1607qa.dts
> @@ -0,0 +1,232 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) 2026, Daniel Carter <yass27106@gmail.com>
> + */
> +
> +/dts-v1/;
> +
> +#include "purwa.dtsi"
> +#include "x1-asus-vivobook-s15.dtsi"

[Severity: Medium]
Should the eDP panel node under mdss_dp3 be overridden for the 16-inch
Vivobook 16 X1607QA?

x1-asus-vivobook-s15.dtsi defines the panel for the 15.6-inch Vivobook S 15:

arch/arm64/boot/dts/qcom/x1-asus-vivobook-s15.dtsi:mdss_dp3 {
    ...
	aux-bus {
		panel {
			compatible = "samsung,atna56ac03", "samsung,atna33xc20";
			enable-gpios = <&pmc8380_3_gpios 4 GPIO_ACTIVE_HIGH>;
			power-supply = <&vreg_edp_3p3>;
    ...
}

Without overriding this node, the 16-inch X1607QA inherits the 15.6-inch
(2880x1620, 16:9) Samsung ATNA56AC03 AMOLED panel description and binds
the atna33xc20 driver, which enforces Samsung AMOLED power-cycling delays
and DP AUX backlight control rather than matching the 16-inch panel on
this laptop.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/45f11591823b4395aa19dd3a3ee6dc90@gmail.com?part=2

      parent reply	other threads:[~2026-11-16 21:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 20:55 [PATCH v5 0/3] arm64: dts: qcom: add device tree for Asus Vivobook 16 X1607QA Daniel Carter
2026-11-16 20:55 ` [PATCH v5 1/3] dt-bindings: arm: qcom: document " Daniel Carter
2026-11-16 20:55   ` [PATCH v5 2/3] arm64: dts: qcom: add device tree for " Daniel Carter
2026-11-16 20:55     ` [PATCH v5 3/3] soundwire: qcom: check clk_prepare_enable() return values Daniel Carter
2026-11-16 21:11     ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-217692@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=yass27106@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox