From: sashiko-bot@kernel.org
To: "Stanislav Aleksandrov" <lightofmysoul@gmail.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v2 2/2] cpufreq: dt-platdev: Add Halliday to blocklist
Date: Mon, 16 Nov 2026 21:32:12 +0000 [thread overview]
Message-ID: <sashiko-outbox-217729@kernel.org> (raw)
In-Reply-To: <20261116-halliday-cpufreq-v2-2-e518cc055457@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] cpufreq: dt-platdev: undocumented DT compatible string
qcom,halliday
--
commit 4e273fe3306a2bb3a253890da522236eca532a54
Author: Stanislav Aleksandrov <lightofmysoul@gmail.com>
cpufreq: dt-platdev: Add Halliday to blocklist
This commit adds "qcom,halliday" to the cpufreq-dt-platdev blocklist so
that the platform uses the qcom-cpufreq-hw driver instead.
> diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c
> index bce4c87573a18..3d5709eaa08fe 100644
> --- a/drivers/cpufreq/cpufreq-dt-platdev.c
> +++ b/drivers/cpufreq/cpufreq-dt-platdev.c
> @@ -155,6 +155,7 @@ static const struct of_device_id blocklist[] __initconst = {
> { .compatible = "nvidia,tegra234", },
>
> { .compatible = "qcom,apq8096", },
> + { .compatible = "qcom,halliday", },
[Severity: Low]
Should "qcom,halliday" be documented in
Documentation/devicetree/bindings/arm/qcom.yaml before adding it to
blocklist[]?
Commit "dt-bindings: cpufreq: qcom-hw: Document Halliday CPUFREQ
hardware" documents "qcom,halliday-cpufreq-epss", but the root SoC
compatible string "qcom,halliday" is not yet documented in the
Devicetree bindings.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-halliday-cpufreq-v2-0-e518cc055457@gmail.com?part=2
prev parent reply other threads:[~2026-11-16 21:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 21:25 [PATCH v2 0/2] Add cpufreq support for Qualcomm Halliday (SXR2250P) Stanislav Aleksandrov
2026-11-16 21:25 ` [PATCH v2 1/2] dt-bindings: cpufreq: qcom-hw: Document Halliday CPUFREQ hardware Stanislav Aleksandrov
2026-11-16 21:25 ` [PATCH v2 2/2] cpufreq: dt-platdev: Add Halliday to blocklist Stanislav Aleksandrov
2026-11-16 21:32 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-217729@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lightofmysoul@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox