Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Fabio Estevam" <festevam@gmail.com>
Cc: linux-input@vger.kernel.org, mfd@lists.linux.dev,
	devicetree@vger.kernel.org, imx@lists.linux.dev, robh@kernel.org,
	conor+dt@kernel.org, Frank.Li@kernel.org,
	dmitry.torokhov@gmail.com, lee@kernel.org
Subject: Re: [PATCH v4 3/4] mfd: mxs-lradc: Pass parent IRQs to child drivers
Date: Mon, 16 Nov 2026 23:04:16 +0000	[thread overview]
Message-ID: <sashiko-outbox-217846@kernel.org> (raw)
In-Reply-To: <20261116224803.61154-3-festevam@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] mfd: mxs-lradc: commit message mismatches MMIO mapping in
  mxs_lradc_probe()
--

commit 7eada64ceb6fbaa203e6af701a0c04cb0afc5c33
Author: Fabio Estevam <festevam@gmail.com>

mfd: mxs-lradc: Pass parent IRQs to child drivers

This commit resolves LRADC interrupts and maps the MMIO region in the MFD
parent driver, sharing them with the ADC and touchscreen child drivers via
struct mxs_lradc instead of passing child platform resources.

> Resolve the interrupts with platform_get_irq() in the MFD parent and
> store the mapped IRQs in the shared LRADC data. Drop the child IRQ
> resources and duplicated name arrays, and have both child drivers
> request the mapped IRQs directly. Use the MFD memory base support to
> translate a single relative memory resource shared by both cells.

[Severity: Low]
Does the last sentence of this paragraph still match the code?

mxs_lradc_probe() maps the MMIO region once into lradc->base via
devm_platform_ioremap_resource() and passes NULL for mem_base to
devm_mfd_add_devices(), while both child drivers use lradc->base directly
without any IORESOURCE_MEM resources in mxs_lradc_cells[].

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261116224803.61154-1-festevam@gmail.com?part=3

  parent reply	other threads:[~2026-11-16 23:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 22:48 [PATCH v4 1/4] dt-bindings: mfd: mxs-lradc: Fix interrupt order Fabio Estevam
2026-11-16 22:48 ` [PATCH v4 2/4] iio: adc: mxs-lradc: Fix trigger use-after-free on removal Fabio Estevam
2026-11-16 22:48 ` [PATCH v4 3/4] mfd: mxs-lradc: Pass parent IRQs to child drivers Fabio Estevam
2026-11-16 22:51   ` Fabio Estevam
2026-11-16 23:04   ` sashiko-bot [this message]
2026-11-16 22:48 ` [PATCH v4 4/4] mfd: mxs-lradc: Convert to devm_clk_get_enabled() Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-217846@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=Frank.Li@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=lee@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=mfd@lists.linux.dev \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox