Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Chi-Wen Weng" <cwweng.linux@gmail.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v5 2/3] dt-bindings: iio: adc: Add Nuvoton MA35D1 EADC
Date: Tue, 17 Nov 2026 08:42:06 +0000	[thread overview]
Message-ID: <sashiko-outbox-218423@kernel.org> (raw)
In-Reply-To: <20261117082832.1551574-3-cwweng.linux@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] dt-bindings: iio: adc: ma35d1-eadc: missing io-channel
  specifier for VBAT
--

commit 9ca0b0a7e74294912e1ef88df7980f863b72d4d7
Author: Chi-Wen Weng <cwweng@nuvoton.com>

dt-bindings: iio: adc: Add Nuvoton MA35D1 EADC

This commit adds the Device Tree binding schema for the Nuvoton MA35D1
Enhanced Analog-to-Digital Converter (EADC).

> diff --git a/Documentation/devicetree/bindings/iio/adc/nuvoton,ma35d1-eadc.yaml b/Documentation/devicetree/bindings/iio/adc/nuvoton,ma35d1-eadc.yaml
> new file mode 100644
> index 0000000000000..1bf64913d67db
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/nuvoton,ma35d1-eadc.yaml
[ ... ]
> +  The external inputs can be used as eight single-ended channels or as
> +  four fixed differential pairs: 0-4, 1-5, 2-6 and 3-7. The VBAT input
> +  needs no devicetree description.
[ ... ]
> +  '#io-channel-cells':
> +    const: 1
> +    description:
> +      The cell selects the logical external EADC channel identified by the reg
> +      value of the corresponding channel child node. Only channels represented
> +      by child nodes are valid I/O channel specifiers.

[Severity: Medium]
As reported by Jonathan Cameron on v3 [1], how can a devicetree IIO
consumer reference the internal VBAT channel if VBAT has no child node and
#io-channel-cells only allows specifiers matching channel@[0-7] child
nodes?

The anyOf constraint also requires at least one channel@[0-7] child node,
preventing a board from using the EADC purely for VBAT monitoring without
defining an external channel node, and adding a VBAT specifier later would
require changing the #io-channel-cells binding contract.

[1] https://lore.kernel.org/r/20261101001934.23588aa2@jic23-hlaptop

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261117082832.1551574-1-cwweng.linux@gmail.com?part=2

  reply	other threads:[~2026-11-17  8:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17  8:28 [PATCH v5 0/3] iio: adc: Add Nuvoton MA35D1 EADC support Chi-Wen Weng
2026-11-17  8:28 ` [PATCH v5 1/3] dt-bindings: iio: adc: Fix channel property validation Chi-Wen Weng
2026-11-17  8:28 ` [PATCH v5 2/3] dt-bindings: iio: adc: Add Nuvoton MA35D1 EADC Chi-Wen Weng
2026-11-17  8:42   ` sashiko-bot [this message]
2026-11-17  8:28 ` [PATCH v5 3/3] iio: adc: Add Nuvoton MA35D1 EADC driver Chi-Wen Weng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-218423@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=cwweng.linux@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox