From: sashiko-bot@kernel.org
To: "Caleb James DeLisle" <cjd@cjdns.fr>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v12 1/5] dt-bindings: timer: econet: Update EN751627 for multi-IRQ
Date: Tue, 17 Nov 2026 10:01:54 +0000 [thread overview]
Message-ID: <sashiko-outbox-218561@kernel.org> (raw)
In-Reply-To: <20261117095117.173316-2-cjd@cjdns.fr>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dt-bindings: timer: econet: unwieldy per-compatible conditionals
in schema
--
commit 03be033e22c76ce913aa7cba221851095ea46465
Author: Caleb James DeLisle <cjd@cjdns.fr>
dt-bindings: timer: econet: Update EN751627 for multi-IRQ
This commit updates the EcoNet HPT binding for EN751627 to drop the
econet,en751221-timer fallback compatible and require four per-VPE
interrupts instead of a single shared percpu-devid interrupt.
> diff --git a/Documentation/devicetree/bindings/timer/econet,en751221-timer.yaml b/Documentation/devicetree/bindings/timer/econet,en751221-timer.yaml
> index c1e7c2b6afde1..ac25785ecfdf6 100644
> --- a/Documentation/devicetree/bindings/timer/econet,en751221-timer.yaml
> +++ b/Documentation/devicetree/bindings/timer/econet,en751221-timer.yaml
> @@ -12,24 +12,23 @@ maintainers:
> description:
> The EcoNet High Precision Timer (HPT) is a timer peripheral found in various
> EcoNet SoCs, including the EN751221 and EN751627 families. It provides per-VPE
> - count/compare registers and a per-CPU control register, with a single interrupt
> - line using a percpu-devid interrupt mechanism.
> + count/compare registers and a per-CPU control register. On EN751221 it uses a
> + single interrupt line using a percpu-devid interrupt mechanism, and on
> + EN751627 it uses an interrupt per VPE.
>
> properties:
> compatible:
> - oneOf:
> - - const: econet,en751221-timer
> - - items:
> - - const: econet,en751627-timer
> - - const: econet,en751221-timer
> + enum:
> + - econet,en751221-timer
> + - econet,en751627-timer
>
> reg:
> minItems: 1
> maxItems: 2
>
> interrupts:
> - maxItems: 1
> - description: A percpu-devid timer interrupt shared across CPUs.
> + minItems: 1
> + maxItems: 4
>
> clocks:
> maxItems: 1
> @@ -52,21 +51,31 @@ allOf:
> items:
> - description: VPE timers 0 and 1
> - description: VPE timers 2 and 3
> + interrupts:
> + description: An interrupt for each timer (one per VPE)
> + minItems: 4
> else:
> properties:
> reg:
> items:
> - description: VPE timers 0 and 1
> + interrupts:
> + description: A percpu-devid timer interrupt shared across timers
> + maxItems: 1
[Severity: Low]
This isn't a bug, but once econet,en751627-timer drops the
econet,en751221-timer fallback and defines its own reg and interrupts
schemas in the if/else block, only clocks (maxItems: 1) remains shared
between the two variants. Would it be cleaner to split
econet,en751627-timer into its own binding schema document rather than
defining most of the binding inside the conditional?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261117095117.173316-1-cjd@cjdns.fr?part=1
next prev parent reply other threads:[~2026-11-17 10:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 9:51 [PATCH v12 0/5] clocksource/timer-econet-en751221: Support irq number per timer Caleb James DeLisle
2026-11-17 9:51 ` [PATCH v12 1/5] dt-bindings: timer: econet: Update EN751627 for multi-IRQ Caleb James DeLisle
2026-11-17 10:01 ` sashiko-bot [this message]
2026-11-17 9:51 ` [PATCH v12 2/5] clocksource/timer-econet-en751221: Init teardown on error if possible Caleb James DeLisle
2026-11-17 9:51 ` [PATCH v12 3/5] clocksource/timer-econet-en751221: Disable IRQ until cevt registered Caleb James DeLisle
2026-11-17 10:01 ` sashiko-bot
2026-11-17 9:51 ` [PATCH v12 4/5] clocksource/timer-econet-en751221: Support EN751627 without percpu IRQ Caleb James DeLisle
2026-11-17 9:51 ` [PATCH v12 5/5] clocksource/timer-econet-en751221: Do not use NR_CPUS for resource array size Caleb James DeLisle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-218561@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=cjd@cjdns.fr \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox