Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: yy-Local-LLM <yogo.0917.sabu@gmail.com>, devicetree@vger.kernel.org
Cc: linux-input@vger.kernel.org, robh@kernel.org,
	conor+dt@kernel.org, dmitry.torokhov@gmail.com
Subject: Re: [PATCH RFC 1/6] dt-bindings: add SiRF AT550 and Yupiteru YPL514si descriptions
Date: Tue, 17 Nov 2026 13:21:56 +0000	[thread overview]
Message-ID: <sashiko-outbox-218867@kernel.org> (raw)
In-Reply-To: <20261117-at550-rfc-v1-v1-1-5879573cb825@gmail.com>

Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [High] dt-bindings: sirf: non-human handle yy-Local-LLM in
  Signed-off-by and maintainers
- [Medium] dt-bindings: sirf: AT550 schemas encode driver and firmware
  limits instead of hardware
--

commit 2d786eae9bbdb4eb26a31d6594cf77ebf8a38f4c
Author: yy-Local-LLM <yogo.0917.sabu@gmail.com>

dt-bindings: add SiRF AT550 and Yupiteru YPL514si descriptions

This commit adds Devicetree binding schemas for the SiRF AT550 platform,
touchscreen, interrupt controller, SDHCI controller, and system timer, along
with the Yupiteru vendor prefix and a MAINTAINERS entry.

> diff --git a/Documentation/devicetree/bindings/input/touchscreen/sirf,at550-ts.yaml b/Documentation/devicetree/bindings/input/touchscreen/sirf,at550-ts.yaml
> new file mode 100644
> index 0000000000000..0458db2419c3c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/touchscreen/sirf,at550-ts.yaml
> @@ -0,0 +1,36 @@
[ ... ]
> +allOf:
> +  - $ref: touchscreen.yaml#
> +
> +properties:
> +  compatible:
> +    const: sirf,at550-ts
> +  reg:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +
> +unevaluatedProperties: false
[ ... ]
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/sirf,at550-intc.yaml b/Documentation/devicetree/bindings/interrupt-controller/sirf,at550-intc.yaml
> new file mode 100644
> index 0000000000000..ec68afa805e94
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interrupt-controller/sirf,at550-intc.yaml
> @@ -0,0 +1,46 @@
[ ... ]
> +description:
> +  The AT550 controller routes 64 level-sensitive interrupt sources to the
> +  ARM1136 IRQ input. Each source has a fixed active level; the single interrupt
> +  cell is the source number. Firmware FIQ routes are not exposed by this driver.
[ ... ]
> diff --git a/Documentation/devicetree/bindings/mmc/sirf,at550-sdhci.yaml b/Documentation/devicetree/bindings/mmc/sirf,at550-sdhci.yaml
> new file mode 100644
> index 0000000000000..7129aaeec2bb7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mmc/sirf,at550-sdhci.yaml
> @@ -0,0 +1,51 @@
[ ... ]
> +description:
> +  AT550 removable SD controller. Initial support uses programmed I/O and
> +  firmware-configured clocks and pin multiplexing. DMA address translation
> +  and 1.8 V operation are not described by this binding.
> +
> +allOf:
> +  - $ref: mmc-controller.yaml#
> +
> +properties:
> +  compatible:
> +    const: sirf,at550-sdhci
> +  reg:
> +    maxItems: 1
> +  interrupts:
> +    maxItems: 1
> +  bus-width:
> +    enum: [1, 4]
> +  no-1-8-v: true
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - no-1-8-v
> +
> +unevaluatedProperties: false
[ ... ]
> diff --git a/Documentation/devicetree/bindings/timer/sirf,at550-timer.yaml b/Documentation/devicetree/bindings/timer/sirf,at550-timer.yaml
> new file mode 100644
> index 0000000000000..d1465d438d10e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/timer/sirf,at550-timer.yaml
> @@ -0,0 +1,47 @@
[ ... ]
> +description:
> +  A free-running counter with six match channels. The Linux driver uses the
> +  low 32 counter bits and match channel zero. Firmware configures the divider
> +  before boot and supplies the resulting counter clock. A running watchdog
> +  must be disabled by firmware before this block is handed to Linux.
> +
> +properties:
> +  compatible:
> +    const: sirf,at550-timer
> +  reg:
> +    maxItems: 1
> +  interrupts:
> +    maxItems: 1
> +  clocks:
> +    items:
> +      - description: Counter clock after the firmware-configured divider

[Severity: Medium]
Should these schemas describe the AT550 hardware capabilities rather than
the current Linux driver implementation and firmware handoff state?

In sirf,at550-ts.yaml, omitting interrupts and clocks while setting
unevaluatedProperties: false causes dtbs_check to reject Devicetrees that
describe the touchscreen interrupt or peripheral clock, since
touchscreen.yaml does not define those properties.

In sirf,at550-sdhci.yaml, clocks is similarly omitted under
unevaluatedProperties: false, and the optional board property no-1-8-v is
made required on all nodes even when 3.3 V-only signaling is implied by the
sirf,at550-sdhci compatible string.

In sirf,at550-timer.yaml, the clock input is defined as the rate after the
firmware-configured divider even though the divider register is internal to
the timer MMIO block, and interrupts is limited to maxItems: 1 despite the
hardware providing six match channels.  The descriptions in
sirf,at550-intc.yaml, sirf,at550-sdhci.yaml, and sirf,at550-timer.yaml also
document Linux driver details rather than the hardware blocks.

[ ... ]

> diff --git a/MAINTAINERS b/MAINTAINERS
> index d738990161bd0..6c3702cd8915a 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -25847,6 +25847,15 @@ F:	drivers/gpio/gpio-siox.c
>  F:	drivers/siox/*
>  F:	include/trace/events/siox.h
>  
> +SIRF AT550 PLATFORM
> +M:	yy-Local-LLM <yogo.0917.sabu@gmail.com>
> +S:	Odd Fixes
> +F:	Documentation/devicetree/bindings/arm/sirf,at550.yaml
> +F:	Documentation/devicetree/bindings/input/touchscreen/sirf,at550-ts.yaml
> +F:	Documentation/devicetree/bindings/interrupt-controller/sirf,at550-intc.yaml
> +F:	Documentation/devicetree/bindings/mmc/sirf,at550-sdhci.yaml
> +F:	Documentation/devicetree/bindings/timer/sirf,at550-timer.yaml

[Severity: High]
The commit Author, Signed-off-by trailer, MAINTAINERS entry, and the
maintainers list in all five new binding schemas use the handle yy-Local-LLM
instead of a known real human full name, which is required by the
Developer's Certificate of Origin in
Documentation/process/submitting-patches.rst.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261117-at550-rfc-v1-v1-0-5879573cb825@gmail.com?part=1

  reply	other threads:[~2026-11-17 13:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 13:06 [PATCH RFC 0/6] SiRF AT550 / YPL514si initial RAM-boot platform support yy-Local-LLM via B4 Relay
2026-11-17 13:06 ` [PATCH RFC 1/6] dt-bindings: add SiRF AT550 and Yupiteru YPL514si descriptions yy-Local-LLM via B4 Relay
2026-11-17 13:21   ` sashiko-bot [this message]
2026-11-17 13:06 ` [PATCH RFC 2/6] irqchip: add the SiRF AT550 interrupt controller yy-Local-LLM via B4 Relay
2026-11-17 13:06 ` [PATCH RFC 3/6] clocksource: add the SiRF AT550 counter and match timer yy-Local-LLM via B4 Relay
2026-11-17 13:06 ` [PATCH RFC 4/6] Input: add polled SiRF AT550 resistive touch support yy-Local-LLM via B4 Relay
2026-11-17 13:06 ` [PATCH RFC 5/6] mmc: sdhci: add SiRF AT550 programmed-I/O support yy-Local-LLM via B4 Relay
2026-11-17 13:06 ` [PATCH RFC 6/6] ARM: add the SiRF AT550 platform and YPL514si board yy-Local-LLM via B4 Relay
2026-11-17 13:17   ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-218867@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=yogo.0917.sabu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox