From: sashiko-bot@kernel.org
To: "Sebastian Reichel" <sebastian.reichel@collabora.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v3 2/9] dt-bindings: devfreq: event: rockchip,dfi: add rk3576
Date: Tue, 17 Nov 2026 15:42:49 +0000 [thread overview]
Message-ID: <sashiko-outbox-219099@kernel.org> (raw)
In-Reply-To: <20261117-rockchip-dfi-rk3588-cleanups-and-rk3576-support-v3-2-32ff1546b0e4@collabora.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dt-bindings: devfreq: rockchip,dfi: unwieldy per-compatible
conditionals
--
commit bdcd31ac4a26427ac56de242bbee17f5338ad380
Author: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
dt-bindings: devfreq: event: rockchip,dfi: add rk3576
This commit adds the rockchip,rk3576-dfi compatible string and its two
required per-channel DFI monitoring clocks to the Rockchip DFI binding
schema.
> diff --git a/Documentation/devicetree/bindings/devfreq/event/rockchip,dfi.yaml b/Documentation/devicetree/bindings/devfreq/event/rockchip,dfi.yaml
> index d6e06a9bea19f..964f1827496ad 100644
> --- a/Documentation/devicetree/bindings/devfreq/event/rockchip,dfi.yaml
> +++ b/Documentation/devicetree/bindings/devfreq/event/rockchip,dfi.yaml
[ ... ]
> @@ -68,6 +69,28 @@ allOf:
> - clocks
> - clock-names
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - rockchip,rk3576-dfi
> + then:
> + properties:
> + clocks:
> + items:
> + - description:
> + clock driving the DDR monitoring logic for memory channel 0
> + - description:
> + clock driving the DDR monitoring logic for memory channel 1
> + clock-names:
> + items:
> + - const: pclk_ddr_mon_ch0
> + - const: pclk_ddr_mon_ch1
> + required:
> + - clocks
> + - clock-names
> +
> - if:
> properties:
> compatible:
[Severity: Low]
This isn't a bug, but each SoC variant in this binding now has different
clock requirements (one clock on rk3399, none on rk3568, two required
per-channel clocks on rk3576, and four optional per-channel clocks on
rk3588), and this block duplicates the per-channel clock descriptions and
clock-names items already listed in the top-level properties and the
rk3588 conditional. Would it be cleaner to split the diverging variants
into separate schema documents, or define the per-channel items once at
the top level and only constrain minItems/maxItems in the conditionals?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261117-rockchip-dfi-rk3588-cleanups-and-rk3576-support-v3-0-32ff1546b0e4@collabora.com?part=2
next prev parent reply other threads:[~2026-11-17 15:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 15:35 [PATCH v3 0/9] PM / devfreq: rockchip-dfi: cleanups and RK3576 support Sebastian Reichel
2026-11-17 15:35 ` [PATCH v3 1/9] dt-bindings: devfreq: event: rockchip,dfi: add clocks to rk3588 Sebastian Reichel
2026-11-17 15:35 ` [PATCH v3 2/9] dt-bindings: devfreq: event: rockchip,dfi: add rk3576 Sebastian Reichel
2026-11-17 15:42 ` sashiko-bot [this message]
2026-11-17 15:35 ` [PATCH v3 3/9] PM / devfreq: rockchip-dfi: move to per-variant const structs Sebastian Reichel
2026-11-17 15:35 ` [PATCH v3 4/9] PM / devfreq: rockchip-dfi: add NO_INTERRUPT perf capability Sebastian Reichel
2026-11-17 15:35 ` [PATCH v3 5/9] PM / devfreq: rockchip-dfi: use bulk clock APIs Sebastian Reichel
2026-11-17 15:35 ` [PATCH v3 6/9] PM / devfreq: rockchip-dfi: make RK3588 use its clocks Sebastian Reichel
2026-11-17 15:48 ` sashiko-bot
2026-11-17 15:35 ` [PATCH v3 7/9] PM / devfreq: rockchip-dfi: move register offsets to variant struct Sebastian Reichel
2026-11-17 15:35 ` [PATCH v3 8/9] PM / devfreq: rockchip-dfi: prepare support for v4 DDRMON Sebastian Reichel
2026-11-17 15:49 ` sashiko-bot
2026-11-17 15:35 ` [PATCH v3 9/9] PM / devfreq: rockchip-dfi: add RK3576 support Sebastian Reichel
2026-11-17 15:54 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-219099@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=sebastian.reichel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox