From: sashiko-bot@kernel.org
To: "Caleb James DeLisle" <cjd@cjdns.fr>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [net-next v5 6/7] dt-bindings: net: dsa: mediatek,mt7530: add EcoNet EN751221 switches
Date: Tue, 17 Nov 2026 18:35:08 +0000 [thread overview]
Message-ID: <sashiko-outbox-219355@kernel.org> (raw)
In-Reply-To: <20261116183332.168858-7-cjd@cjdns.fr>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dt-bindings: net: dsa: mt7530: unaddressed v4 review on en751221
compatibles
--
commit 2cadfb1e611919345d0f3bc419d5f43f6b58423f
Author: Caleb James DeLisle <cjd@cjdns.fr>
dt-bindings: net: dsa: mediatek,mt7530: add EcoNet EN751221 switches
This commit adds the econet,en751221-switch and econet,en751221-gswitch
compatible strings and schema constraints for EcoNet EN751221 switches to
the MediaTek MT7530 DSA binding.
> diff --git a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
> index 590eb39d6b93a..e4e81ed64136b 100644
> --- a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
> +++ b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
[ ... ]
> @@ -110,6 +116,14 @@ properties:
> Built-in switch of the EcoNet EN7528 SoC
> const: econet,en7528-switch
>
> + - description:
> + Built-in switch of EcoNet EN751221 SoC
> + const: econet,en751221-switch
> +
> + - description:
> + Multi-chip module gigabit MT7530 in EN751221 SoC
> + const: econet,en751221-gswitch
[Severity: Low]
As reported by Krzysztof Kozlowski on v4 [1], the description for
econet,en751221-switch repeats the compatible string instead of
distinguishing the on-die switch from the multi-chip module switch, the
description for econet,en751221-gswitch is split across multiple lines, and
it remains unclear why two EN751221 compatibles are added for hardware
described as MT7530.
[1] https://lore.kernel.org/r/20261103-soft-lyrical-squid-c5a108@quoll
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116183332.168858-1-cjd@cjdns.fr?part=6
next prev parent reply other threads:[~2026-11-17 18:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 18:33 [net-next v5 0/7] net: dsa: mt7530: support EcoNet EN751221 Caleb James DeLisle
2026-11-16 18:33 ` [net-next v5 1/7] net: dsa: mt7530: get ctrl phy addr using a function Caleb James DeLisle
2026-11-16 18:33 ` [net-next v5 2/7] dt-bindings: net: dsa: mediatek,mt7530: describe 'passthrough' hierarchy Caleb James DeLisle
2026-11-16 18:33 ` [net-next v5 3/7] net: dsa: mediatek: add support for passthrough mode Caleb James DeLisle
2026-11-17 0:30 ` kernel test robot
2026-11-17 18:35 ` sashiko-bot
2026-11-16 18:33 ` [net-next v5 4/7] net: dsa: mediatek: support PLL setup on MMIO MT7530 Caleb James DeLisle
2026-11-17 18:35 ` sashiko-bot
2026-11-16 18:33 ` [net-next v5 5/7] net: dsa: mediatek: support MDIO switch downstream of MMIO switch Caleb James DeLisle
2026-11-17 18:35 ` sashiko-bot
2026-11-16 18:33 ` [net-next v5 6/7] dt-bindings: net: dsa: mediatek,mt7530: add EcoNet EN751221 switches Caleb James DeLisle
2026-11-17 18:35 ` sashiko-bot [this message]
2026-11-16 18:33 ` [net-next v5 7/7] net: dsa: mediatek: support EN751221 switch Caleb James DeLisle
2026-11-17 18:35 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-219355@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=cjd@cjdns.fr \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox