From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794946292; b=PzcMeBCXoDdsKC5zXazCaDVTqmxcE/Yu/KkDdsMyXfQGmBXUh/IruNxkk8wPEJVe3VkP MKpDWyK9RpXevk8gkCrK70mn8tovgAmGaWKY77u1D03HY7FwW3q6MfRVGilfaedL6Lpa6 UcEUXpy084/aye20Aas1sP664VpmRzC2DPJTw28W9Pq1aUKa2ar5qVixT/VezTZoptkIp tKyQw/Kv0LPqVq17wFnIccs5KBrwRUTcSlY+rtfWjkUSr+KQaSiPepeFWaoM3fGDXtbs0 x8TZhFkxgTsNj58qUG6X3/LQ/6jFVhivsVkQvfxUhzpz1U2YQe512VLI5JtscgNQ1Bg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794946292; h=Received:DKIM-Signature:Message-ID:From:Subject:Reply-To:To:Cc: In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=o1Y/yNbkW2bZMPXGpyxomoYGDfphc/X8oVtcisFJF/w=; b=fRrCsDxQcBUB4wIDFhyc6aNOBjMKBx35nfufaiKmxuZMQjHIHwKIrKFta+zDZqiBw1EG Y3F54m8nNrocgMxmccqrHCxnPiD6Nr8GTYPGQFRial4rMZSbkrmbk6sqTimB5yqG0sk3/ TkMdwAGyBfMaaP0sdg7tRZpwGGSkNOGrTDiWFz81XeatyAm6Cpo+3xtM8Rj15rnTN4vgi uC0RWqjtXSdwo3PzG0QROAiD7roSKUBPmo7RTX0IoU9fcMmt7oPGZJOL/GSHcCLuZaWKt 2H9fBJ05XlO2TDL94uqxiM0td/sHD55L7qIH835EwfXiLi5XCa1jgzaHxPK2iqjyPmA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=mxK01jt4; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5900A606A31C for ; Tue, 17 Nov 2026 20:11:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=mxK01jt4 Received: by smtp.kernel.org (Postfix) with ESMTPSA id B82BB1F000C5; Tue, 17 Nov 2026 20:11:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794946292; bh=o1Y/yNbkW2bZMPXGpyxomoYGDfphc/X8oVtcisFJF/w=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=mxK01jt4UnB6GGRkK3XBjM7Wv9pTSp0H6bwXjTnQrTNecq0e19UljW9rpEbjbLou2 HT051gZxjbrrOFqQZEEhkMRikxEOy8ATUMeXemwAGWbOtdSVTh+KDD3yl8rYoGfFh+ yDOeuBxfYbfClk89EWalLhTbOY22jZv1ufcflwJnyaLtoz855Y7JrAwcPvPYpnSh48 Ms8Zv8AEo5qtbbja0tXJxpDK3K2tOJLCwDCYr7vGiOzK+XTMcVlGpT77h0TPwa67r6 jPBaSryASiMUdgxzpqyRTLDfff3DRr/jfbvfe8jWjYQ+b3xCbJizPA87xoKAVW5RtO X0Ri0s6MRn/Fw== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH 06/10] drm/meson: dw-hdmi: Drop manual HHI clock and memory PD setup Reply-To: sashiko-reviews@lists.linux.dev To: "Ronald Claveau" Cc: devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-phy@lists.infradead.org, dri-devel@lists.freedesktop.org, robh@kernel.org, conor+dt@kernel.org, neil.armstrong@linaro.org, vkoul@kernel.org, olteanv@gmail.com In-Reply-To: <20261117-meson-drm-create-hdmitx-phy-v1-6-9e0ac931381c@aliel.fr> References: <20261117-meson-drm-create-hdmitx-phy-v1-0-9e0ac931381c@aliel.fr> <20261117-meson-drm-create-hdmitx-phy-v1-6-9e0ac931381c@aliel.fr> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 17 Nov 2026 20:11:31 +0000 X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [High] drm/meson: dw-hdmi: skipped HDMITX mem PD power-up in meson_dw_hdmi_init() -- commit c8e782099f758bf635402705a20f57d7df9682a7 Author: Ronald Claveau drm/meson: dw-hdmi: Drop manual HHI clock and memory PD setup This commit removes the direct HHI_HDMI_CLK_CNTL and HHI_MEM_PD_REG0 register writes in meson_dw_hdmi_init() and takes a runtime PM reference in meson_dw_hdmi_probe() to power on the VPU power domain. > diff --git a/drivers/gpu/drm/meson/meson_dw_hdmi.c b/drivers/gpu/drm/meso= n/meson_dw_hdmi.c > index eb33c70f29c31..20a821936b3af 100644 > --- a/drivers/gpu/drm/meson/meson_dw_hdmi.c > +++ b/drivers/gpu/drm/meson/meson_dw_hdmi.c [ ... ] > @@ -599,12 +598,6 @@ static void meson_dw_hdmi_init(struct meson_dw_hdmi = *meson_dw_hdmi) > { > struct meson_drm *priv =3D meson_dw_hdmi->priv; > =20 > - /* Enable clocks */ > - regmap_update_bits(priv->hhi, HHI_HDMI_CLK_CNTL, 0xffff, 0x100); > - > - /* Bring HDMITX MEM output of power down */ > - regmap_update_bits(priv->hhi, HHI_MEM_PD_REG0, 0xff << 8, 0); > - > /* Reset HDMITX APB & TX & PHY */ > reset_control_reset(meson_dw_hdmi->hdmitx_apb); > reset_control_reset(meson_dw_hdmi->hdmitx_ctrl); > @@ -829,9 +822,29 @@ static int __maybe_unused meson_dw_hdmi_pm_resume(st= ruct device *dev) > return 0; > } > =20 > +static void meson_dw_hdmi_pm_put(void *dev) > +{ > + pm_runtime_put_sync(dev); > +} > + > static int meson_dw_hdmi_probe(struct platform_device *pdev) > { > - return component_add(&pdev->dev, &meson_dw_hdmi_ops); > + struct device *dev =3D &pdev->dev; > + int ret; > + > + ret =3D devm_pm_runtime_enable(dev); > + if (ret) > + return ret; > + > + ret =3D pm_runtime_resume_and_get(dev); > + if (ret) > + return dev_err_probe(dev, ret, "Failed to power on HDMI TX\n"); [Severity: High] Can dropping the HHI_MEM_PD_REG0 write leave the HDMITX memory powered down when the bootloader turns on the top-level VPU domain without enabling HDMI? In the VPU power domain driver, pwrc_ee_is_powered_off() only checks the top-level AO sleep bit and does not check HHI_MEM_PD_REG0[15:8]. When the top-level VPU domain is already powered on at boot, meson_ee_pwrc_init_domain() registers the genpd as already on without calling meson_ee_pwrc_on(): drivers/pmdomain/amlogic/meson-ee-pwrc.c:meson_ee_pwrc_init_domain() { ... if (dom->num_clks && dom->desc.is_powered_off && !dom->desc.is_powered_off= (dom)) { ret =3D clk_bulk_prepare_enable(dom->num_clks, dom->clks); if (ret) return ret; dom->base.flags =3D GENPD_FLAG_ALWAYS_ON; ret =3D pm_genpd_init(&dom->base, NULL, false); if (ret) return ret; } ... } Because the genpd is initialized in the ON state with GENPD_FLAG_ALWAYS_ON, pm_runtime_resume_and_get() is a no-op and meson_ee_pwrc_on() never runs to clear HHI_MEM_PD_REG0[15:8], leaving HDMITX memory powered down when meson_dw_hdmi_init() and dw_hdmi_probe() access the controller. In addition, power-domains and assigned-clocks are optional in the amlogic,meson-dw-hdmi binding and were only added to in-tree DTs in v6.11, so dropping the HHI_HDMI_CLK_CNTL and HHI_MEM_PD_REG0 writes also regresses older DTBs (where meson_vclk_set() only configures HHI_HDMI_CLK_CNTL later at atomic_enable time) and builds with CONFIG_PM disabled. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261117-meson-drm-= create-hdmitx-phy-v1-0-9e0ac931381c@aliel.fr?part=3D6