Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Madhavan Ganesan" <madhavan.ganesan@oss.qualcomm.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH ath-next v2 02/15] wifi: ath12k: refactor PCI window selection to per-device layout
Date: Wed, 18 Nov 2026 06:31:11 +0000	[thread overview]
Message-ID: <sashiko-outbox-220253@kernel.org> (raw)
In-Reply-To: <20261118-wifi8_qcn9575_bringup-v2-2-d81a3046290e@oss.qualcomm.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] wifi: ath12k: runtime mask passed to u32_replace_bits() in
  pcic.c
--

commit fea0a3bf22c9a4872fcffbf9f6c11d790f370851
Author: Madhavan Ganesan <madhavan.ganesan@oss.qualcomm.com>

wifi: ath12k: refactor PCI window selection to per-device layout

This commit moves PCI and AHB register window masks and addresses into
per-device structures so device families with different window layouts can
configure their own mappings.

> diff --git a/drivers/net/wireless/ath/ath12k/pcic.c b/drivers/net/wireless/ath/ath12k/pcic.c
> index b6d306fd3b99f..c10e21d688303 100644
> --- a/drivers/net/wireless/ath/ath12k/pcic.c
> +++ b/drivers/net/wireless/ath/ath12k/pcic.c

[ ... ]

> @@ -32,20 +38,21 @@ static int ath12k_pcic_select_static_window(struct ath12k_base *ab, u32 addr)
>  	const int max_retries = 10;
>  	int i;
>  
> -	window_bits = u32_get_bits(addr, WINDOW_VALUE_MASK);
> +	window_bits = field_get(ab_ahb->reg_base->window_value_mask, addr);
>  
> -	/* Update window bits [5:0], preserving other bits */
> -	new_window = u32_replace_bits(ab_ahb->static_window_reg, window_bits, 0x3f);
> +	/* Update the dynamic window bits, preserving the static window configuration */
> +	new_window = u32_replace_bits(ab_ahb->static_window_reg, window_bits,
> +				      ~ab_ahb->reg_base->window_static_mask);

[Severity: High]
Does passing ~ab_ahb->reg_base->window_static_mask to u32_replace_bits()
break the build when CONFIG_ATH12K_AHB is enabled?

u32_replace_bits() calls u32_encode_bits() -> field_multiplier(), which
requires a compile-time constant mask to eliminate the __compiletime_error
call to __bad_mask().  Because ab_ahb->reg_base is a runtime pointer, the
mask check cannot be folded at compile time.

Updating new_window with field_prep(~ab_ahb->reg_base->window_static_mask,
window_bits) | (ab_ahb->static_window_reg &
ab_ahb->reg_base->window_static_mask), or masking static_window_reg
directly as in ath12k_pci_select_window(), would avoid u32_replace_bits()
on a runtime mask.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261118-wifi8_qcn9575_bringup-v2-0-d81a3046290e@oss.qualcomm.com?part=2

  reply	other threads:[~2026-11-18  6:31 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18  6:19 [PATCH ath-next v2 00/15] wifi: ath12k: add initial Wi-Fi 8 support for QCN9575 Madhavan Ganesan
2026-11-18  6:19 ` [PATCH ath-next v2 01/15] dt-bindings: net: wireless: add ath12k wifi device QCN9575 Madhavan Ganesan
2026-11-18  6:19 ` [PATCH ath-next v2 02/15] wifi: ath12k: refactor PCI window selection to per-device layout Madhavan Ganesan
2026-11-18  6:31   ` sashiko-bot [this message]
2026-11-18  6:19 ` [PATCH ath-next v2 03/15] wifi: ath12k: add extended QMI WLAN cfg for CE and service pipes Madhavan Ganesan
2026-11-18  6:19 ` [PATCH ath-next v2 04/15] wifi: ath12k: add QMI support for extended firmware binary download Madhavan Ganesan
2026-11-18  6:35   ` sashiko-bot
2026-11-18  6:19 ` [PATCH ath-next v2 05/15] wifi: ath12k: add Wi-Fi 8 directory and base module scaffolding Madhavan Ganesan
2026-11-18  6:19 ` [PATCH ath-next v2 06/15] wifi: ath12k: add initial Wi-Fi 8 hw params and init helper for QCN9575 Madhavan Ganesan
2026-11-18  6:19 ` [PATCH ath-next v2 07/15] wifi: ath12k: add Wi-Fi 8 HAL register table and hal init hook " Madhavan Ganesan
2026-11-18  6:19 ` [PATCH ath-next v2 08/15] wifi: ath12k: add Wi-Fi 8 HAL ops and descriptor definitions " Madhavan Ganesan
2026-11-18  6:19 ` [PATCH ath-next v2 09/15] wifi: ath12k: add unified firmware image support " Madhavan Ganesan
2026-11-18  6:19 ` [PATCH ath-next v2 10/15] wifi: ath12k: add Wi-Fi 8 MHI config " Madhavan Ganesan
2026-11-18  6:19 ` [PATCH ath-next v2 11/15] wifi: ath12k: add Wi-Fi 8 CE config and service pipe map " Madhavan Ganesan
2026-11-18  6:19 ` [PATCH ath-next v2 12/15] wifi: ath12k: add Wi-Fi 8 WMI init " Madhavan Ganesan
2026-11-18  6:19 ` [PATCH ath-next v2 13/15] wifi: ath12k: add Wi-Fi 8 hw ops " Madhavan Ganesan
2026-11-18  6:19 ` [PATCH ath-next v2 14/15] wifi: ath12k: add and hook Wi-Fi 8 mac80211 ops skeleton " Madhavan Ganesan
2026-11-18  6:19 ` [PATCH ath-next v2 15/15] wifi: ath12k: add Wi-Fi 8 PCI driver scaffolding " Madhavan Ganesan
2026-11-18  6:34   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-220253@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=madhavan.ganesan@oss.qualcomm.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox