Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Mason Huo" <mason.huo@starfivetech.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH vV 1/2] dt-bindings: ipmi: Convert starfive,kcs-bmc to DT schema
Date: Wed, 18 Nov 2026 06:36:44 +0000	[thread overview]
Message-ID: <sashiko-outbox-220262@kernel.org> (raw)
In-Reply-To: <20261118062526.1436893-2-mason.huo@starfivetech.com>

Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Low] dt-bindings: ipmi: wrong conversion commit message and schema
  filename/$id
- [Low] dt-bindings: ipmi: starfive,kcs-bmc relies on undocumented
  starfive,sio-id
--

commit fc7a7047c07e19a8497c2d87d2a38e97878efe8c
Author: Mason Huo <mason.huo@starfivetech.com>

dt-bindings: ipmi: Convert starfive,kcs-bmc to DT schema

This commit adds a DT schema binding for StarFive JHB100 BMC KCS devices.

> diff --git a/Documentation/devicetree/bindings/ipmi/starfive,kcs-bmc.yaml b/Documentation/devicetree/bindings/ipmi/starfive,kcs-bmc.yaml
> new file mode 100644
> index 0000000000000..2cb91d321a324
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/ipmi/starfive,kcs-bmc.yaml
> @@ -0,0 +1,53 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/ipmi/starfive,kcs-bmc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: StarFive BMC KCS Devices
> +
> +maintainers:
> +  - Mason Huo <mason.huo@starfivetech.com>
> +
> +description:
> +  The StarFive BMC SoCs use Keyboard-Controller-Style (KCS) interfaces on
> +  the eSPI bus for in-band IPMI communication with their host. The KCS
> +  channels are part of a Super I/O (SIO) block and each channel occupies a
> +  0x100 byte register window, starting at offset 0x200 of the SIO register
> +  space. A channel is identified by its register offset and the
> +  "starfive,sio-id" of the parent SIO node.

[Severity: Low]
Where are the parent SIO node and its starfive,sio-id property documented?
Neither the parent StarFive SIO binding nor starfive,sio-id exists in any
DT schema, the example below omits the parent node, and
Documentation/devicetree/bindings/writing-bindings.rst advises against
adding custom instance index properties.

> +
> +properties:
> +  compatible:
> +    enum:
> +      - starfive,jhb100-kcs-bmc

[Severity: Low]
Should the schema filename and $id be starfive,jhb100-kcs-bmc.yaml to match
the sole compatible string, as required by
Documentation/devicetree/bindings/writing-bindings.rst?

Also, the commit subject and message state that this converts an existing
starfive,kcs-bmc binding to DT schema format, but no prior StarFive KCS
binding existed in the tree.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261118062526.1436893-1-mason.huo@starfivetech.com?part=1

  reply	other threads:[~2026-11-18  6:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18  6:25 [PATCH 0/2] ipmi: Add StarFive JHB100 KCS BMC driver Mason Huo
2026-11-18  6:25 ` [PATCH vV 1/2] dt-bindings: ipmi: Convert starfive,kcs-bmc to DT schema Mason Huo
2026-11-18  6:36   ` sashiko-bot [this message]
2026-11-18  6:25 ` [PATCH vV 2/2] ipmi: add StarFive KCS BMC driver Mason Huo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-220262@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=mason.huo@starfivetech.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox