From: sashiko-bot@kernel.org
To: "Zhanpeng Zhang" <zhangzhanpeng.jasper@bytedance.com>,
linux-perf-users@vger.kernel.org
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [RFC PATCH v1 1/5] dt-bindings: riscv: Add Smpdis and Sspdis ISA extensions
Date: Wed, 18 Nov 2026 08:23:00 +0000 [thread overview]
Message-ID: <sashiko-outbox-220433@kernel.org> (raw)
In-Reply-To: <20261118081327.10684-8-zhangzhanpeng.jasper@bytedance.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] dt-bindings: riscv: unratified draft smpdis and sspdis
extensions added
--
commit 6221314245742eb097a15011dd35eda824258728
Author: Zhanpeng Zhang <zhangzhanpeng.jasper@bytedance.com>
dt-bindings: riscv: Add Smpdis and Sspdis ISA extensions
This commit adds devicetree binding descriptions for the draft Smpdis and
Sspdis RISC-V Precise Decoded Instruction Sampling extensions.
> diff --git a/Documentation/devicetree/bindings/riscv/extensions.yaml b/Documentation/devicetree/bindings/riscv/extensions.yaml
> index 79491ef8f86a8..afda76b9c7c47 100644
> --- a/Documentation/devicetree/bindings/riscv/extensions.yaml
> +++ b/Documentation/devicetree/bindings/riscv/extensions.yaml
> @@ -214,6 +214,15 @@ properties:
> ratified at commit d70011dde6c2 ("Update to ratified state")
> of riscv-j-extension.
>
> + - const: smpdis
> + description: |
> + The draft Smpdis machine-level extension for Precise Decoded
> + Instruction Sampling, as described at commit
> + 2de60e18118ce78e2da82ec33296345c94d8560c of the
> + riscv-performance-event-sampling specification. It defines
> + instruction selection, filtering and sample collection across
> + privilege levels. This does not imply supervisor access to PDIS.
> +
> - const: smstateen
> description: |
> The standard Smstateen extension for controlling access to CSRs
> @@ -269,6 +278,16 @@ properties:
> ratified at commit d70011dde6c2 ("Update to ratified state")
> of riscv-j-extension.
>
> + - const: sspdis
> + description: |
> + The draft Sspdis supervisor-level extension for Precise Decoded
> + Instruction Sampling, as described at commit
> + 2de60e18118ce78e2da82ec33296345c94d8560c of the
> + riscv-performance-event-sampling specification. It provides the
> + supervisor-visible PDIS registers and behavior, excluding the
> + machine-only state. Firmware must make this state accessible to
> + supervisor software before reporting this extension.
> +
[Severity: Medium]
Should unratified, unfrozen draft specifications claim the canonical
smpdis and sspdis strings in riscv,isa-extensions?
Documentation/devicetree/bindings/riscv/extensions.yaml states that
standard extension properties map to their originally ratified states, and
Documentation/arch/riscv/patch-acceptance.rst requires RISC-V
specifications to be Frozen or Ratified before acceptance. Defining
unversioned standard extension names for a draft without final CSR
allocations breaks devicetree ABI stability if the specification or CSRs
change before ratification.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261118081327.10684-7-zhangzhanpeng.jasper@bytedance.com?part=1
next prev parent reply other threads:[~2026-11-18 8:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 8:13 [RFC PATCH v1 0/5] RISC-V: Add perf support for PDIS Zhanpeng Zhang
2026-11-18 8:13 ` [RFC PATCH v1 1/5] dt-bindings: riscv: Add Smpdis and Sspdis ISA extensions Zhanpeng Zhang
2026-11-18 8:23 ` sashiko-bot [this message]
2026-11-18 8:13 ` [RFC PATCH v1 2/5] riscv: Detect " Zhanpeng Zhang
2026-11-18 8:13 ` [RFC PATCH v1 3/5] perf: riscv: Probe the experimental PDIS CSR layout on matching CPUs Zhanpeng Zhang
2026-11-18 8:13 ` [RFC PATCH v1 4/5] perf: riscv: Add PDIS event and counter callbacks Zhanpeng Zhang
2026-11-18 8:13 ` [RFC PATCH v1 5/5] perf: riscv: Deliver PDIS samples through the SBI PMU interrupt Zhanpeng Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-220433@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=zhangzhanpeng.jasper@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox