Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Cunhao Lu" <1579567540@qq.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH net-next v4 1/2] dt-bindings: net: rockchip-dwmac: Add RK3572
Date: Wed, 18 Nov 2026 09:04:46 +0000	[thread overview]
Message-ID: <sashiko-outbox-220526@kernel.org> (raw)
In-Reply-To: <20261117-add-board-ok3572-c-net-v4-1-4e9da569395a@qq.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dt-bindings: net: rockchip-dwmac: unwieldy per-compatible
  if-then blocks
--

commit a665a5efbe3f2f5557e38aac986038f5502fc0a1
Author: Cunhao Lu <1579567540@qq.com>

dt-bindings: net: rockchip-dwmac: Add RK3572

This commit adds the rockchip,rk3572-gmac compatible string to the Rockchip
and Synopsys DWMAC binding schemas, requires rockchip,php-grf for it, and
deprecates tx_delay and rx_delay while disallowing them on RK3572.

> diff --git a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml
> index e8dda1961ab31..d7b7bb0082357 100644
> --- a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml

[ ... ]

> @@ -141,11 +145,22 @@ required:
>  allOf:
>    - $ref: snps,dwmac.yaml#
>  
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: rockchip,rk3572-gmac
> +    then:
> +      properties:
> +        rx_delay: false
> +        tx_delay: false
> +
>    - if:
>        properties:
>          compatible:
>            contains:
>              enum:
> +              - rockchip,rk3572-gmac
>                - rockchip,rk3576-gmac
>                - rockchip,rk3588-gmac
>      then:

[Severity: Low]
This isn't a bug, but rockchip-dwmac.yaml already covers 16 SoC variants
across multiple IP generations and has accumulated several per-compatible
if-then blocks in allOf for rockchip,php-grf, clocks, phy-mode, and
pcs-handle. Would it be cleaner to split this binding into separate schema
documents rather than piling on more per-compatible conditionals?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261117-add-board-ok3572-c-net-v4-0-4e9da569395a@qq.com?part=1

  reply	other threads:[~2026-11-18  9:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17  9:04 [PATCH net-next v4 0/2] net: stmmac: Add RK3572 support Cunhao Lu via B4 Relay
2026-11-17  9:04 ` [PATCH net-next v4 1/2] dt-bindings: net: rockchip-dwmac: Add RK3572 Cunhao Lu via B4 Relay
2026-11-18  9:04   ` sashiko-bot [this message]
2026-11-17  9:04 ` [PATCH net-next v4 2/2] net: stmmac: dwmac-rk: Add RK3572 support Cunhao Lu via B4 Relay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-220526@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=1579567540@qq.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox