From: sashiko-bot@kernel.org
To: "Wang Yang" <yang.wang@deepcomputing.io>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 8/9] riscv: dts: spacemit: Enable the FML13V05 EC keyboard
Date: Wed, 18 Nov 2026 09:20:38 +0000 [thread overview]
Message-ID: <sashiko-outbox-220542@kernel.org> (raw)
In-Reply-To: <20261118085742.1817536-9-yang.wang@deepcomputing.io>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] riscv: dts: spacemit: espi0_2_cfg uses bare bias-pull-up
instead of <0>
--
commit 032746cb10950441af76e89d1f8e24310fb7d057
Author: Wang Yang <yang.wang@deepcomputing.io>
riscv: dts: spacemit: Enable the FML13V05 EC keyboard
This commit enables the eSPI controller and adds the embedded controller
and keyboard matrix node to the DeepComputing FML13V05 board device tree.
> diff --git a/arch/riscv/boot/dts/spacemit/k3-deepcomputing-fml13v05.dts b/arch/riscv/boot/dts/spacemit/k3-deepcomputing-fml13v05.dts
> index b5d5112de3581..214c8bbb52f06 100644
> --- a/arch/riscv/boot/dts/spacemit/k3-deepcomputing-fml13v05.dts
> +++ b/arch/riscv/boot/dts/spacemit/k3-deepcomputing-fml13v05.dts
> @@ -3,6 +3,8 @@
> * Copyright (C) 2026 DeepComputing (HK) Limited
> */
>
> +#include <dt-bindings/input/input.h>
> +
> #include "k3.dtsi"
> #include "k3-pinctrl.dtsi"
>
> @@ -29,3 +31,138 @@ &uart0 {
> pinctrl-0 = <&uart0_0_cfg>;
> status = "okay";
> };
> +
> +&espi0 {
> + pinctrl-0 = <&espi0_2_cfg>;
[Severity: Medium]
Does selecting espi0_2_cfg program a strong pull-up on the eSPI pins
instead of the intended normal pull-up?
arch/riscv/boot/dts/spacemit/k3-pinctrl.dtsi:
espi0_2_cfg: espi0-2-cfg {
espi0-0-pins {
...
bias-pull-up; /* normal pull-up */
Unlike the other normal pull-up groups in k3-pinctrl.dtsi that specify
bias-pull-up = <0>, espi0-0-pins omits the cell value. When no value is
given, parse_fw_cfg() supplies the default argument 1 for
PIN_CONFIG_BIAS_PULL_UP, which causes spacemit_pinconf_generate_config()
in drivers/pinctrl/spacemit/pinctrl-k1.c to set PAD_STRONG_PULL (and
fails dtbs_check against spacemit,k1-pinctrl.yaml, which requires 0 or
1).
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261118085742.1817536-1-yang.wang@deepcomputing.io?part=8
next prev parent reply other threads:[~2026-11-18 9:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 8:57 [PATCH 0/9] Add SpacemiT K3 FML13V05 EC keyboard support Wang Yang
2026-11-18 8:57 ` [PATCH 1/9] dt-bindings: bus: Add SpacemiT K3 eSPI controller Wang Yang
2026-11-18 9:18 ` sashiko-bot
2026-11-18 8:57 ` [PATCH 2/9] dt-bindings: embedded-controller: Add SpacemiT K3 EC window Wang Yang
2026-11-18 8:57 ` [PATCH 3/9] bus: Add SpacemiT K3 eSPI controller support Wang Yang
2026-11-18 9:23 ` sashiko-bot
2026-11-18 8:57 ` [PATCH 4/9] platform/chrome: Allow ChromeOS platform support on RISC-V Wang Yang
2026-11-18 8:57 ` [PATCH 5/9] platform/chrome: Add SpacemiT K3 eSPI EC transport Wang Yang
2026-11-18 8:57 ` [PATCH 6/9] riscv: dts: spacemit: Add K3 eSPI pin group Wang Yang
2026-11-18 9:08 ` sashiko-bot
2026-11-18 8:57 ` [PATCH 7/9] riscv: dts: spacemit: Describe the K3 eSPI controller Wang Yang
2026-11-18 9:25 ` sashiko-bot
2026-11-18 8:57 ` [PATCH 8/9] riscv: dts: spacemit: Enable the FML13V05 EC keyboard Wang Yang
2026-11-18 9:20 ` sashiko-bot [this message]
2026-11-18 8:57 ` [PATCH 9/9] riscv: defconfig: Enable the FML13V05 EC keyboard modules Wang Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-220542@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=yang.wang@deepcomputing.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox