Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Petko Manolov" <petko.manolov@konsulko.com>
Cc: devicetree@vger.kernel.org, imx@lists.linux.dev, robh@kernel.org,
	conor+dt@kernel.org, Frank.Li@kernel.org
Subject: Re: [PATCH v4 2/2] arm: dts: nxp: imx: Add devicetree files for M48
Date: Wed, 18 Nov 2026 09:24:11 +0000	[thread overview]
Message-ID: <sashiko-outbox-220551@kernel.org> (raw)
In-Reply-To: <20261118090914.38082-3-petko.manolov@konsulko.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] ARM: dts: imx: undocumented draeger vendor prefix in M48 board
  compatibles
--

commit 4a3279abe9868d1f357238a507cb14a2a1c89b59
Author: Petko Manolov <petko.manolov@konsulko.com>

arm: dts: nxp: imx: Add devicetree files for M48

This commit adds devicetree files for the i.MX6 DualLite and i.MX6 Quad
variants of the Draeger M48 board.

> diff --git a/arch/arm/boot/dts/nxp/imx/imx6dl-draeger-m48.dts b/arch/arm/boot/dts/nxp/imx/imx6dl-draeger-m48.dts
> new file mode 100644
> index 0000000000000..b0bc9a67f5b34
> --- /dev/null
> +++ b/arch/arm/boot/dts/nxp/imx/imx6dl-draeger-m48.dts
> @@ -0,0 +1,16 @@
[ ... ]
> +/ {
> +	model = "Draeger M48 i.MX6 DualLite";
> +	compatible = "draeger,imx6dl-m48", "fsl,imx6dl";
> +};
> diff --git a/arch/arm/boot/dts/nxp/imx/imx6q-draeger-m48.dts b/arch/arm/boot/dts/nxp/imx/imx6q-draeger-m48.dts
> new file mode 100644
> index 0000000000000..ff9c337e93fbf
> --- /dev/null
> +++ b/arch/arm/boot/dts/nxp/imx/imx6q-draeger-m48.dts
> @@ -0,0 +1,16 @@
[ ... ]
> +/ {
> +	model = "Draeger M48 i.MX6 Quad";
> +	compatible = "draeger,imx6q-m48", "fsl,imx6q";
> +};

[Severity: Low]
Should the "draeger" vendor prefix be documented in
Documentation/devicetree/bindings/vendor-prefixes.yaml?  Without an entry
for "^draeger,.*", scripts/checkpatch.pl and devicetree schema validation
report an undocumented vendor prefix warning for "draeger,imx6dl-m48" and
"draeger,imx6q-m48".

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261118090914.38082-1-petko.manolov@konsulko.com?part=2

  reply	other threads:[~2026-11-18  9:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18  9:09 [PATCH v4 0/2] arm: dts: nxp: imx: add Draeger M48 CPU board Petko Manolov
2026-11-18  9:09 ` [PATCH v4 1/2] dt-bindings: arm: fsl: add Draeger M48 dual-cpu board Petko Manolov
2026-11-18  9:24   ` sashiko-bot
2026-11-18  9:09 ` [PATCH v4 2/2] arm: dts: nxp: imx: Add devicetree files for M48 Petko Manolov
2026-11-18  9:24   ` sashiko-bot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-10-22 14:02 [PATCH v4 0/2] arm: dts: nxp: imx: add Draeger M48 CPU board Petko Manolov
2026-10-22 14:02 ` [PATCH v4 2/2] arm: dts: nxp: imx: Add devicetree files for M48 Petko Manolov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-220551@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=Frank.Li@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=imx@lists.linux.dev \
    --cc=petko.manolov@konsulko.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox