From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795028941; b=gWrMCK/j9/lPADgkx/8k4qCeLQ9XBXqw519x1+Bl3asvJ7oGp9r3tXHD0OM5C8XXsggV uKsRnOsbTOwsluXxe+vmPrNNjw+aqf4TnnMyJ6Tp+LLyNxEogIAJOOQLOQgjGX7UFn1Ga 7OtWwI5YcwdfnXKud0AHEs5EKKTtQXeuLvrcPcDNZNvmWDEKK74/wpnczLrjN133EPA/w HQ4eaYXgjbixfWU4PBBY2sw7IZ2dgUIguaD60CgR3BzRS7dH4RWyXkgOodDpFzwghBydj xRQHmuA6i15+qVWQl4WEIVUTsRY37m2O0XrU0z7A0aBMG/Gd89uP2QHcYv7aeeoNYMw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795028941; h=Received:DKIM-Signature:Message-ID:From:Subject:Reply-To:To:Cc: In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=7c8ppuunIdtFjvUrjCDWTw1becCkmfL7Vf+hBZTuAWs=; b=Ly9ZZiACtZhZrw99as8fHmqa89zUm6WxIoHF5Lmgcv3l4W68humHoJjZz9jf7qbWs+ZV 5ooYw8QEsE9+j37uAxTqBBiSd8Fju3TGpCwd+9qZjFzM0vgtxOaLZ/TBiuF4H9ZUHuKw8 OhVVMdQaI9N8lToIYLCYVcFyP+I3hyTJrwUfBHOpNB1mxNTKXuB8hGJqABh0CgkRVTV1n zXT4hWbletos6zNu5uIZW8ZVPpDS+3yoB2hrrNmkBp6pzfH6N4ebxDfv/kO4uhBdAE5cD G4pMjcpZZrZrC28gcA+GKXK7KVJqO87HjZqYJDw5cxIOnmMS+P0gYMCbh89FRN0mAfA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=SNd0u1Ft; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DEC4A60A2600 for ; Wed, 18 Nov 2026 19:09:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=SNd0u1Ft Received: by smtp.kernel.org (Postfix) with ESMTPSA id 618AF1F000C4; Wed, 18 Nov 2026 19:09:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1795028941; bh=7c8ppuunIdtFjvUrjCDWTw1becCkmfL7Vf+hBZTuAWs=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=SNd0u1FtLMCP4FsOjVjU0piGYQyKOhXRcLIrelZsERTot3gJOx2Ev8F/wL7/SwjfX KbePEsL5R+xgr2nH0lKVWHK2Md0DV5eBDyuyz7LYJw/oK7i3AaZNlqollE8FGHl+wF 6GUcIOW6SzD/LPlRrGL/oVRmdMlLkEZ897laIDCPHN+e0QQN5WqohZybqG6hc8cYp+ H2+VRGtqEeg7JCBVUNaO2zlacqi1OYhrpJEE+xoGSXtFzaMEZCKGExdZl6XLNdphoG 218UyUf2R+HrNc9OrMr8oyy/Vfrd49Jibgy9vnMb58XgP413HvLhrdZFBkwKwhVHiy 54vgf5VglsvhQ== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v2] riscv: dts: spacemit: k1: add PowerVR GPU device node Reply-To: sashiko-reviews@lists.linux.dev To: "Iker Pedrosa" Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org In-Reply-To: <20261118-orangepi-gpu-v2-1-f68676f844eb@gmail.com> References: <20261118-orangepi-gpu-v2-1-f68676f844eb@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Wed, 18 Nov 2026 19:09:00 +0000 X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [High] riscv: dts: spacemit: build failure from missing spacemit,k1-power.h header -- commit efc5334efe329206674ea5227e542cbbf6e41d33 Author: Iker Pedrosa riscv: dts: spacemit: k1: add PowerVR GPU device node This commit adds the PowerVR Rogue GPU device tree node for the SpacemiT K1 SoC and enables it by default. > diff --git a/arch/riscv/boot/dts/spacemit/k1.dtsi b/arch/riscv/boot/dts/s= pacemit/k1.dtsi > index 5d5f7f8a393d3..15bee2137e14e 100644 > --- a/arch/riscv/boot/dts/spacemit/k1.dtsi > +++ b/arch/riscv/boot/dts/spacemit/k1.dtsi > @@ -5,6 +5,7 @@ > =20 > #include > #include > +#include > =20 > #include "k1-pdma.h" > =20 > @@ -1119,6 +1120,16 @@ multimedia-bus { > #size-cells =3D <2>; > dma-ranges =3D <0x0 0x00000000 0x0 0x00000000 0x0 0x80000000>, > <0x0 0x80000000 0x1 0x00000000 0x3 0x80000000>; > + > + gpu: gpu@cac00000 { > + compatible =3D "spacemit,k1-gpu", "img,img-bxe-2-32", "img,img-rogue= "; > + reg =3D <0x0 0xcac00000 0x0 0x80000>; > + interrupts =3D <75>; > + clocks =3D <&syscon_apmu CLK_GPU>; > + clock-names =3D "core"; > + resets =3D <&syscon_apmu RESET_GPU>; > + power-domains =3D <&syscon_apmu K1_PMDOMAIN_GPU>; > + }; > }; > =20 > network-bus { [Severity: High] Does this break the DTB build when CONFIG_ARCH_SPACEMIT is enabled? Neither include/dt-bindings/power/spacemit,k1-power.h nor K1_PMDOMAIN_GPU is present in the tree yet, so preprocessing any SpacemiT K1 board DTS that includes k1.dtsi fails until the prerequisite power-domain series is applied. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261118-orangepi-g= pu-v2-1-f68676f844eb@gmail.com?part=3D1