Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Bartosz Golaszewski" <bartosz.golaszewski@oss.qualcomm.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v3 2/2] arm64: dts: qcom: lemans-sa8255p: add ethernet nodes
Date: Thu, 19 Nov 2026 10:05:15 +0000	[thread overview]
Message-ID: <sashiko-outbox-222909@kernel.org> (raw)
In-Reply-To: <20261118-sa8255p-emac-dts-v3-2-e2c365d95a0b@oss.qualcomm.com>

Thank you for your contribution! Sashiko AI review found 3 potential
issues to consider:
- [Low] arm64: dts: qcom: lemans-sa8255p-ride: non-compliant MDIO PHY
  nodes
- [Low] arm64: dts: qcom: lemans-sa8255p-ride: out-of-order serdes label
  nodes
- [Low] arm64: dts: qcom: lemans-sa8255p-ride: invalid snps,ps-speed =
  <2500>
--

commit 15bc324c5c1543ac7a9409abaa0230b88cd074cf
Author: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>

arm64: dts: qcom: lemans-sa8255p: add ethernet nodes

This commit adds the ethernet and serdes PHY nodes for the gearvm variant
of the Lemans SA8255P Ride board and enables the corresponding SCMI nodes.

> diff --git a/arch/arm64/boot/dts/qcom/lemans-sa8255p-ride.dts b/arch/arm64/boot/dts/qcom/lemans-sa8255p-ride.dts
> index 6f19064997a4b..991626589cc34 100644
> --- a/arch/arm64/boot/dts/qcom/lemans-sa8255p-ride.dts
> +++ b/arch/arm64/boot/dts/qcom/lemans-sa8255p-ride.dts
[ ... ]
> @@ -101,6 +103,173 @@ trip1 {
>  	};
>  };
>  
> +&ethernet0 {
> +	phy-handle = <&hsgmii_phy0>;
> +	phy-mode = "2500base-x";
> +
> +	pinctrl-0 = <&ethernet0_default>;
> +	pinctrl-names = "default";
> +
> +	snps,mtl-rx-config = <&mtl_rx_setup>;
> +	snps,mtl-tx-config = <&mtl_tx_setup>;
> +	snps,ps-speed = <2500>;

[Severity: Low]
Should snps,ps-speed = <2500> be dropped from both ethernet0 and
ethernet1?

stmmac_check_pcs_mode() only uses snps,ps-speed for MAC-to-MAC SGMII links
and only accepts 10, 100, or 1000, whereas both nodes here use external
PHYs with phy-mode = "2500base-x".

> +
> +	status = "okay";
> +
> +	mdio {
> +		compatible = "snps,dwmac-mdio";
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		hsgmii_phy0: phy@8 {
> +			compatible = "ethernet-phy-id31c3.1c33";
> +			reg = <0x8>;
> +			device_type = "ethernet-phy";
> +			resets = <&scmi7_rst 0>;
> +			reset-names = "phy";
> +			reset-assert-us = <11000>;
> +			reset-deassert-us = <70000>;
> +		};
> +
> +		hsgmii_phy1: phy@0 {
> +			compatible = "ethernet-phy-id31c3.1c33";
> +			reg = <0x0>;
> +			device_type = "ethernet-phy";
> +			resets = <&scmi8_rst 0>;
> +			reset-names = "phy";
> +			reset-assert-us = <11000>;
> +			reset-deassert-us = <70000>;
> +		};
> +	};

[Severity: Low]
Should these MDIO child nodes be named ethernet-phy@0 and ethernet-phy@8?

Documentation/devicetree/bindings/net/ethernet-phy.yaml selects nodes
matching ^ethernet-phy(@[a-f0-9]+)?$, while snps,dwmac.yaml references
mdio.yaml with unevaluatedProperties: false, so naming them phy@8 and
phy@0 leaves compatible, resets, and reset-names unevaluated during
dtbs_check.

Also, device_type = "ethernet-phy" is deprecated and rejected by dtschema,
and unit address 0 should be ordered before unit address 8.

[ ... ]

> @@ -205,6 +398,14 @@ pcie1_ep_wake_default: pcie1-ep-wake-default-state {
>  	};
>  };
>  
> +&serdes0 {
> +	status = "okay";
> +};
> +
> +&serdes1 {
> +	status = "okay";
> +};

[Severity: Low]
This isn't a bug, but &serdes0 and &serdes1 are placed after &tlmm instead
of in alphabetical order between &scmi23 and &sleep_clk.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261118-sa8255p-emac-dts-v3-0-e2c365d95a0b@oss.qualcomm.com?part=2

      reply	other threads:[~2026-11-19 10:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 10:05 [PATCH v3 0/2] arm64: dts: qcom: sa8255p: add ethernet nodes Bartosz Golaszewski
2026-11-18 10:05 ` [PATCH v3 1/2] arm64: dts: qcom: lemans: fix iommus SID mask for " Bartosz Golaszewski
2026-11-18 10:05 ` [PATCH v3 2/2] arm64: dts: qcom: lemans-sa8255p: add " Bartosz Golaszewski
2026-11-19 10:05   ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-222909@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=bartosz.golaszewski@oss.qualcomm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox