Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Jacky Huang" <jackyhuang@nvidia.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v4 2/2] ARM: dts: aspeed: Add NVIDIA MGX Vera C2 BMC
Date: Thu, 19 Nov 2026 10:29:53 +0000	[thread overview]
Message-ID: <sashiko-outbox-222955@kernel.org> (raw)
In-Reply-To: <dc78c9c1aea306be5a3c4b06a9a85969b2ee6913.1795081735.git.jackyhuang@nvidia.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] ARM: dts: aspeed: address 0x20 collision across i2c4 sibling
  pca9548 muxes
--

commit 6911a14b6d0cba62b8d23c81ced73b37efb2136f
Author: Jacky Huang <jackyhuang@nvidia.com>

ARM: dts: aspeed: Add NVIDIA MGX Vera C2 BMC

This commit adds the device tree for the ASPEED AST2600 BMC on the
NVIDIA MGX Vera C2 server reference platform.

Link: https://www.nvidia.com/en-us/data-center/products/mgx/
Link: https://www.nvidia.com/en-us/data-center/vera-cpu/

> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-nvidia-vr-c2-bmc.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-nvidia-vr-c2-bmc.dts
> new file mode 100644
> index 0000000000000..ecbcff048f5cd
> --- /dev/null
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-nvidia-vr-c2-bmc.dts

[ ... ]

> +/* MCIO expansion muxes */
> +&i2c4 {
> +	multi-master;
> +
> +	status = "okay";
> +
> +	mctp@18 {
> +		compatible = "mctp-i2c-controller";
> +		reg = <(0x18 | I2C_OWN_SLAVE_ADDRESS)>;
> +	};
> +
> +	i2c-mux@70 {
> +		compatible = "nxp,pca9548";
> +		reg = <0x70>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		vdd-supply = <&standby_power_regulator>;

[ ... ]

> +	i2c-mux@71 {
> +		compatible = "nxp,pca9548";
> +		reg = <0x71>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		vdd-supply = <&standby_power_regulator>;

[ ... ]

> +	i2c-mux@75 {
> +		compatible = "nxp,pca9548";
> +		reg = <0x75>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		vdd-supply = <&standby_power_regulator>;

[ ... ]

> +/* GPU0 GPIO expander */
> +&i2c_mcio_c0_south2 {
> +	/* GPU 0, Expander @0x20 */
> +	gpio@20 {
> +		compatible = "nxp,pca6408";
> +		reg = <0x20>;
> +		gpio-controller;
> +		#gpio-cells = <2>;
> +		vcc-supply = <&standby_power_regulator>;
> +		gpio-line-names =
> +			"GPU0_GLOBAL_WP-O",
> +			"GPU0_OOB_RST_N-O",
> +			"GPU0_OOB_RECOVERY-O",
> +			"GPU0_MCU_RECOVERY_N-O",
> +			"GPU0_MCU_RST_N-O",
> +			"GPU0_MCU_BYPASS_N-O",
> +			"GPU0_SMBUS_FRU_EEPROM_WP-O",
> +			"";
> +	};
> +};
> +
> +/* E1.S backplane GPIO expander (C2) */
> +&i2c_mcio_c0c1_north6 {
> +	/* E1S Backplane, Expander @0x20 */
> +	gpio@20 {
> +		compatible = "nxp,pca6408";
> +		reg = <0x20>;
> +		gpio-controller;
> +		#gpio-cells = <2>;
> +		vcc-supply = <&standby_power_regulator>;
> +		gpio-line-names =
> +			"E1S_MCU_RESET_L-O",
> +			"E1S_MCU_RECOVERY_L-O",
> +			"",
> +			"",
> +			"",
> +			"",
> +			"E1S_LOWER_PERST-O",
> +			"E1S_UPPER_PERST-O";
> +	};
> +};
> +
> +/* GPU1 GPIO expander (C2) */
> +&i2c_mcio_c1_south0 {
> +	/* GPU 1, Expander @0x20 */
> +	gpio@20 {
> +		compatible = "nxp,pca6408";
> +		reg = <0x20>;

[Severity: High]
Will the three pca6408 expanders at 0x20 collide on i2c4 because
i2c-mux@70, i2c-mux@71 and i2c-mux@75 lack i2c-mux-idle-disconnect?

Without i2c-mux-idle-disconnect, pca954x leaves each switch's last
selected channel connected after a transfer, and selecting a channel on
one switch does not deselect the sibling switches on i2c4.  Once the
three gpio@20 expanders on i2c_mcio_c0_south2, i2c_mcio_c0c1_north6 and
i2c_mcio_c1_south0 have been accessed, all three remain bridged onto
i2c4 at address 0x20 simultaneously, causing bus contention and making
writes to one expander drive the other two as well.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1795081735.git.jackyhuang@nvidia.com?part=2

  reply	other threads:[~2026-11-19 10:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 10:16 [PATCH v4 0/2] ARM: dts: aspeed: Add NVIDIA MGX Vera C2 BMC support Jacky Huang
2026-11-19 10:16 ` [PATCH v4 1/2] dt-bindings: arm: aspeed: Add NVIDIA MGX Vera C2 BMC Jacky Huang
2026-11-19 10:16 ` [PATCH v4 2/2] ARM: dts: " Jacky Huang
2026-11-19 10:29   ` sashiko-bot [this message]
2026-11-19 10:40     ` Jacky Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-222955@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jackyhuang@nvidia.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox