Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Max Merchel" <Max.Merchel@ew.tq-group.com>
Cc: devicetree@vger.kernel.org, imx@lists.linux.dev, robh@kernel.org,
	conor+dt@kernel.org, Frank.Li@kernel.org
Subject: Re: [PATCH] ARM: dts: imx6qdl-mba6: Add EEPROM nvmem cell for all board information
Date: Thu, 19 Nov 2026 10:37:08 +0000	[thread overview]
Message-ID: <sashiko-outbox-222965@kernel.org> (raw)
In-Reply-To: <20261119102531.2995127-1-Max.Merchel@ew.tq-group.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] ARM: dts: imx6qdl-mba6: duplicate @20 unit-address in
  nvmem-layout
--

commit b5a0ac272fe3356ca3f0ff5cbf739f7f5d760dab
Author: Max Merchel <Max.Merchel@ew.tq-group.com>

ARM: dts: imx6qdl-mba6: Add EEPROM nvmem cell for all board information

This commit adds an EEPROM fixed-layout nvmem cell at offset 0x20 covering
board information on MBa6a and MBa6b carrier boards.

> diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6a.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6a.dtsi
> index aca320ee8f476..9b199b277c220 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6a.dtsi
> +++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6a.dtsi
> @@ -29,6 +29,10 @@ nvmem-layout {
>  			#address-cells = <1>;
>  			#size-cells = <1>;
>  
> +			board_info: board-info@20 {
> +				reg = <0x20 0x60>;
> +			};
> +
>  			mba_mac_address: mac-address@20 {
>  				reg = <0x20 0x6>;
>  			};
> diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6b.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6b.dtsi
> index c7bbd6195fef1..517913abbc66d 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6b.dtsi
> +++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6b.dtsi
> @@ -39,6 +39,10 @@ nvmem-layout {
>  			#address-cells = <1>;
>  			#size-cells = <1>;
>  
> +			board_info: board-info@20 {
> +				reg = <0x20 0x60>;
> +			};
> +
>  			mba_mac_address: mac-address@20 {
>  				reg = <0x20 0x6>;
>  			};

[Severity: Low]
Does adding board-info@20 alongside mac-address@20 under the same
nvmem-layout parent in both dtsi files cause duplicate unit-address dtc
warnings?

Because both enabled sibling nodes share the @20 unit-address and overlap
at offset 0x20, building the MBa6x DTBs with W=1 or W=2 triggers
unique_unit_address_if_enabled and unique_unit_address warnings.  Could the
fields be defined as non-overlapping cells at their respective offsets, or
exposed through a dedicated nvmem layout?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261119102531.2995127-1-Max.Merchel@ew.tq-group.com?part=1

      reply	other threads:[~2026-11-19 10:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 10:25 [PATCH] ARM: dts: imx6qdl-mba6: Add EEPROM nvmem cell for all board information Max Merchel
2026-11-19 10:37 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-222965@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=Frank.Li@kernel.org \
    --cc=Max.Merchel@ew.tq-group.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=imx@lists.linux.dev \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox